Bug 124651 - Don't paint simple text runs outside the paint rect
Summary: Don't paint simple text runs outside the paint rect
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-20 03:27 PST by Antti Koivisto
Modified: 2013-11-20 07:12 PST (History)
4 users (show)

See Also:


Attachments
patch (9.46 KB, patch)
2013-11-20 03:43 PST, Antti Koivisto
andersca: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2013-11-20 03:27:06 PST
optimize
Comment 1 Antti Koivisto 2013-11-20 03:43:51 PST
Created attachment 217416 [details]
patch
Comment 2 Anders Carlsson 2013-11-20 06:53:19 PST
Comment on attachment 217416 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=217416&action=review

> Source/WebCore/rendering/SimpleLineLayoutFunctions.cpp:90
>          auto run = *it;

I think this copies the run. Maybe it should be const auto& instead?
Comment 3 Antti Koivisto 2013-11-20 07:12:06 PST
https://trac.webkit.org/r159560