Bug 124636 - [EFL] Activate keyboard homepage shortcut on efl Minibrowser
Summary: [EFL] Activate keyboard homepage shortcut on efl Minibrowser
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-19 22:22 PST by Jongwoo Choi
Modified: 2013-12-25 19:02 PST (History)
3 users (show)

See Also:

Attachments
Patch (1.46 KB, patch)
2013-11-19 22:26 PST, Jongwoo Choi 		no flags Details | Formatted Diff | Diff
Patch (1.52 KB, patch)
2013-12-05 22:34 PST, Jongwoo Choi 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jongwoo Choi 2013-11-19 22:22:49 PST 
Activate keyboard homepage shortcut on efl minibrowser using Alt+Home key like other browsers.
Comment 1 Jongwoo Choi 2013-11-19 22:26:52 PST 
Created attachment 217385 [details]
Patch
Comment 2 Gyuyoung Kim 2013-12-05 21:51:27 PST 
Comment on attachment 217385 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=217385&action=review

LGTM

> Tools/ChangeLog:8
> +        * MiniBrowser/efl/main.c:

I prefer to add any description even though it is very small.
Comment 3 Jongwoo Choi 2013-12-05 22:34:50 PST 
Created attachment 218571 [details]
Patch
Comment 4 Jongwoo Choi 2013-12-05 22:36:39 PST 
Add description after function name in changelog.
Comment 5 WebKit Commit Bot 2013-12-25 19:02:35 PST 
Comment on attachment 218571 [details]
Patch

Clearing flags on attachment: 218571

Committed r161082: <http://trac.webkit.org/changeset/161082>
Comment 6 WebKit Commit Bot 2013-12-25 19:02:39 PST 
All reviewed patches have been landed.  Closing bug.