Bug 124635 – Cleanup getOrEstablishIDBDatabaseMetadata and stub it out in WK2

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Brady Eidson]

Cleanup getOrEstablishIDBDatabaseMetadata and stub it out in WK2

-getOrEstablishIDBDatabaseMetadata should not have to take a database name parameter because the server connection should already know what database name it represents.
-Stub out the message for getOrEstablishIDBDatabaseMetadata in the DatabaseProcess in WK2

[Brady Eidson]

Created attachment 217383 [details]
Patch v1

[Sam Weinig]

You forgot the code I think.

[Brady Eidson]

(In reply to comment #2)
> You forgot the code I think.

One of these days, git and I will get along.

[Brady Eidson]

Created attachment 217384 [details]
Patch v1 with code.

[Tim Horton]

Comment on attachment 217384 [details]
Patch v1 with code.

View in context: https://bugs.webkit.org/attachment.cgi?id=217384&action=review

> Source/WebCore/Modules/indexeddb/IDBFactoryBackendInterface.h:-63
> -    virtual void open(const String& name, uint64_t version, int64_t transactionId, PassRefPtr<IDBCallbacks>, PassRefPtr<IDBDatabaseCallbacks>, const SecurityOrigin& openingOrigin, const SecurityOrigin& mainFrameOrigin) = 0;

what's with the deconstification? (will probably be explained later in the patch). Weren't we bitten by mutable securityorigins in the past?

[Brady Eidson]

http://trac.webkit.org/changeset/159563