Bug 124635 - Cleanup getOrEstablishIDBDatabaseMetadata and stub it out in WK2
Summary: Cleanup getOrEstablishIDBDatabaseMetadata and stub it out in WK2
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-19 22:18 PST by Brady Eidson
Modified: 2013-11-20 07:57 PST (History)
4 users (show)

See Also:

Attachments
Patch v1 (2.99 KB, patch)
2013-11-19 22:21 PST, Brady Eidson 		no flags Details | Formatted Diff | Diff
Patch v1 with code. (22.64 KB, patch)
2013-11-19 22:25 PST, Brady Eidson 		thorton: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2013-11-19 22:18:53 PST 
Cleanup getOrEstablishIDBDatabaseMetadata and stub it out in WK2

-getOrEstablishIDBDatabaseMetadata should not have to take a database name parameter because the server connection should already know what database name it represents.
-Stub out the message for getOrEstablishIDBDatabaseMetadata in the DatabaseProcess in WK2
Comment 1 Brady Eidson 2013-11-19 22:21:07 PST 
Created attachment 217383 [details]
Patch v1
Comment 2 Sam Weinig 2013-11-19 22:22:12 PST 
You forgot the code I think.
Comment 3 Brady Eidson 2013-11-19 22:25:10 PST 
(In reply to comment #2)
> You forgot the code I think.

One of these days, git and I will get along.
Comment 4 Brady Eidson 2013-11-19 22:25:31 PST 
Created attachment 217384 [details]
Patch v1 with code.
Comment 5 Tim Horton 2013-11-19 23:17:25 PST 
Comment on attachment 217384 [details]
Patch v1 with code.

View in context: https://bugs.webkit.org/attachment.cgi?id=217384&action=review

> Source/WebCore/Modules/indexeddb/IDBFactoryBackendInterface.h:-63
> -    virtual void open(const String& name, uint64_t version, int64_t transactionId, PassRefPtr<IDBCallbacks>, PassRefPtr<IDBDatabaseCallbacks>, const SecurityOrigin& openingOrigin, const SecurityOrigin& mainFrameOrigin) = 0;

what's with the deconstification? (will probably be explained later in the patch). Weren't we bitten by mutable securityorigins in the past?
Comment 6 Brady Eidson 2013-11-20 07:57:59 PST 
http://trac.webkit.org/changeset/159563