Bug 124612 - REGRESSION(158384) ARMv7 pointer checks too restrictive for native calls to traditional ARM code
Summary: REGRESSION(158384) ARMv7 pointer checks too restrictive for native calls to t...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Michael Saboff
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-19 15:19 PST by Michael Saboff
Modified: 2013-11-19 16:32 PST (History)
0 users

See Also:

Attachments
Patch (3.23 KB, patch)
2013-11-19 16:04 PST, Michael Saboff 		ggaren: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Saboff 2013-11-19 15:19:15 PST 
The DFG JIT calls out to math library functions like sin().  Those functions might be implemented as traditional ARM functions and therefore fail the ASSERT(reinterpret_cast<intptr_t>(ptr) & 1) test in ASSERT_VALID_CODE_POINTER().
Comment 1 Michael Saboff 2013-11-19 15:47:51 PST 
There are other checks like ASSERT(reinterpret_cast<intptr_t>(to) & 1) in ARMv7Assembler::linkCall().
Comment 2 Michael Saboff 2013-11-19 16:04:34 PST 
Created attachment 217349 [details]
Patch
Comment 3 Geoffrey Garen 2013-11-19 16:15:47 PST 
Comment on attachment 217349 [details]
Patch

r=me
Comment 4 Mark Lam 2013-11-19 16:20:00 PST 
Comment on attachment 217349 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=217349&action=review

> Source/JavaScriptCore/assembler/MacroAssemblerCodeRef.h:43
> +// decorated and undectorated null.

Should fix the pre-existing typo: "undectorated" ==> "undecorated".
Comment 5 Michael Saboff 2013-11-19 16:29:11 PST 
(In reply to comment #4)
> (From update of attachment 217349 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=217349&action=review
> 
> > Source/JavaScriptCore/assembler/MacroAssemblerCodeRef.h:43
> > +// decorated and undectorated null.
> 
> Should fix the pre-existing typo: "undectorated" ==> "undecorated".

I made this change.
Comment 6 Michael Saboff 2013-11-19 16:32:43 PST 
Committed r159532: <http://trac.webkit.org/changeset/159532>