Bug 124598 – [WebIDL] Interface objects and interface prototype objects should be spec-compliant

• Status: NEW
• Component: New Bugs

[Zan Dobersek]

[WebIDL] Interface objects and interface prototype objects should be spec-compliant

[Zan Dobersek]

Created attachment 217318 [details]
WIP

[Zan Dobersek]

(In reply to comment #1)
> Created an attachment (id=217318) [details]
> WIP

This is a WIP patch that will be split further to simplify the reviews.

The introduced changes try to bring the functionality of the interface objects and interface prototype objects in line with the specification and other Web engines.

The constructor property is moved from the platform objects to the interface prototype objects.
The prototype property on the interface objects is now non-writable, non-deletable and non-enumerable.
Interface objects are made callable, though in all cases a type error is thrown (which shouldn't be the case for Constructor-annotated interfaces).
Interface objects now all have the 'Function' class name and inherit from JSC::InternalFunction.

Two things that still need doing are removing support for the ReplaceableConstructor attribute and making the constructors actually replaceable.

I'll be running this patch through EWS to gather test results on the Mac port, to see if there's anything else failing and what needs further rebaselining.

[Build Bot]

Comment on attachment 217318 [details]
WIP

Attachment 217318 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/28588009

New failing tests:
fast/dom/Window/window-lookup-precedence.html
css3/compositing/background-blend-mode-property-parsing.html
js/dom/global-constructors-attributes.html
css3/filters/custom/custom-filter-property-computed-style.html
css3/filters/custom/custom-filter-mix-bindings.html
css3/compositing/blend-mode-property-parsing.html
css3/filters/custom/custom-filter-property-parsing.html
css3/filters/filter-property-parsing.html

[Build Bot]

Created attachment 217328 [details]
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-14  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

[Build Bot]

Comment on attachment 217318 [details]
WIP

Attachment 217318 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/25938030

New failing tests:
fast/dom/Window/window-lookup-precedence.html
css3/compositing/background-blend-mode-property-parsing.html
js/dom/global-constructors-attributes.html
css3/filters/custom/custom-filter-property-computed-style.html
css3/filters/custom/custom-filter-mix-bindings.html
css3/compositing/blend-mode-property-parsing.html
css3/filters/custom/custom-filter-property-parsing.html
css3/filters/filter-property-parsing.html

[Build Bot]

Created attachment 217345 [details]
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-01  Port: mac-mountainlion  Platform: Mac OS X 10.8.5

[Build Bot]

Comment on attachment 217318 [details]
WIP

Attachment 217318 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/23438237

New failing tests:
fast/dom/Window/window-lookup-precedence.html
css3/compositing/background-blend-mode-property-parsing.html
js/dom/global-constructors-attributes.html
css3/filters/custom/custom-filter-property-computed-style.html
css3/filters/custom/custom-filter-mix-bindings.html
css3/compositing/blend-mode-property-parsing.html
css3/filters/custom/custom-filter-property-parsing.html
css3/filters/filter-property-parsing.html

[Build Bot]

Created attachment 217357 [details]
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-08  Port: mac-mountainlion  Platform: Mac OS X 10.8.5