Consolidate IDBBackingStore*Interface and IDBBackingStore*LevelDB There's no longer a need for the Interface abstractions, as the LevelDB implementations will be the only ones.
Created attachment 217319 [details] Patch v1
Attachment 217319 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/Modules/indexeddb/IDBBackingStoreCursorInterface.h', u'Source/WebCore/Modules/indexeddb/IDBBackingStoreInterface.h', u'Source/WebCore/Modules/indexeddb/IDBBackingStoreTransactionInterface.h', u'Source/WebCore/Modules/indexeddb/IDBServerConnection.h', u'Source/WebCore/Modules/indexeddb/leveldb/IDBBackingStoreCursorLevelDB.h', u'Source/WebCore/Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.cpp', u'Source/WebCore/Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.h', u'Source/WebCore/Modules/indexeddb/leveldb/IDBBackingStoreTransactionLevelDB.h', u'Source/WebCore/Modules/indexeddb/leveldb/IDBIndexWriterLevelDB.cpp', u'Source/WebCore/Modules/indexeddb/leveldb/IDBIndexWriterLevelDB.h', u'Source/WebCore/Modules/indexeddb/leveldb/IDBServerConnectionLevelDB.cpp', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj']" exit_code: 1 Source/WebCore/Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.cpp:545: Extra space before ( in function call [whitespace/parens] [4] Source/WebCore/Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.cpp:663: Extra space before ( in function call [whitespace/parens] [4] Source/WebCore/Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.h:79: Extra space before ( in function call [whitespace/parens] [4] Source/WebCore/Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.h:80: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 4 in 8 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 217319 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=217319&action=review > Source/WebCore/Modules/indexeddb/leveldb/IDBBackingStoreCursorLevelDB.h:60 > + virtual PassRefPtr<IDBKey> key() const { return m_currentKey; } Why PassRefPtr?! > Source/WebCore/Modules/indexeddb/leveldb/IDBBackingStoreCursorLevelDB.h:68 > + virtual PassRefPtr<IDBKey> primaryKey() const { return m_currentKey; } > + virtual PassRefPtr<SharedBuffer> value() const = 0; Ditto.
(In reply to comment #3) > (From update of attachment 217319 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=217319&action=review > > > Source/WebCore/Modules/indexeddb/leveldb/IDBBackingStoreCursorLevelDB.h:60 > > + virtual PassRefPtr<IDBKey> key() const { return m_currentKey; } > > Why PassRefPtr?! > > > Source/WebCore/Modules/indexeddb/leveldb/IDBBackingStoreCursorLevelDB.h:68 > > + virtual PassRefPtr<IDBKey> primaryKey() const { return m_currentKey; } > > + virtual PassRefPtr<SharedBuffer> value() const = 0; > > Ditto. Great question - It always was from the original LevelDB implementors, and I think it was just wrong. Not sure i should change it, though, without the ability to test.
http://trac.webkit.org/changeset/159517