Bug 124570 - Web Inspector: layer info sidebar should convert to MB for very large layers
Summary: Web Inspector: layer info sidebar should convert to MB for very large layers
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-11-19 01:32 PST by Antoine Quint
Modified: 2013-11-19 12:32 PST (History)
5 users (show)

See Also:

Attachments
testcase (84 bytes, text/html)
2013-11-19 01:32 PST, Antoine Quint 		no flags Details
Patch (1.75 KB, patch)
2013-11-19 02:12 PST, Antoine Quint 		no flags Details | Formatted Diff | Diff
Patch for landing (1.75 KB, patch)
2013-11-19 12:00 PST, Antoine Quint 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2013-11-19 01:32:24 PST 
Created attachment 217278 [details]
testcase

Really big layers can overflow the width of the 'memory' column. Really, we should probably convert to MB for layers >= 10MB or so.
Comment 1 Antoine Quint 2013-11-19 01:32:34 PST 
<rdar://problem/15432691>
Comment 2 Antoine Quint 2013-11-19 02:12:21 PST 
Created attachment 217280 [details]
Patch
Comment 3 Joseph Pecoraro 2013-11-19 10:28:13 PST 
Comment on attachment 217280 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=217280&action=review

> Source/WebInspectorUI/ChangeLog:8
> +        Setting higherResolution to true (its default value if ommitted) when calling

Typo: "ommitted" => "omitted"
Comment 4 Antoine Quint 2013-11-19 12:00:01 PST 
Created attachment 217314 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2013-11-19 12:32:29 PST 
Comment on attachment 217314 [details]
Patch for landing

Clearing flags on attachment: 217314

Committed r159514: <http://trac.webkit.org/changeset/159514>
Comment 6 WebKit Commit Bot 2013-11-19 12:32:30 PST 
All reviewed patches have been landed.  Closing bug.