'text' can never be empty as it's already been checked.
Created attachment 217273 [details] Patch
(In reply to comment #0) > 'text' can never be empty as it's already been checked. Where does the check happen? It looks like "shouldInsertText" is effectively a delegate, and we have no specific say over what it does. Do you mean that the "text.isEmpty()" test always happens before Editor::insertTextWithoutSendingTextEvent?
(In reply to comment #2) > (In reply to comment #0) > > 'text' can never be empty as it's already been checked. > > Where does the check happen? It looks like "shouldInsertText" is effectively a delegate, and we have no specific say over what it does. > > Do you mean that the "text.isEmpty()" test always happens before Editor::insertTextWithoutSendingTextEvent? It's been checked at top of Editor::insertTextWithoutSendingTextEvent(). (See : http://trac.webkit.org/browser/trunk/Source/WebCore/editing/Editor.cpp#L958 )
(In reply to comment #3) > (In reply to comment #2) > > (In reply to comment #0) > > > 'text' can never be empty as it's already been checked. > > > > Where does the check happen? It looks like "shouldInsertText" is effectively a delegate, and we have no specific say over what it does. > > > > Do you mean that the "text.isEmpty()" test always happens before Editor::insertTextWithoutSendingTextEvent? > > > It's been checked at top of Editor::insertTextWithoutSendingTextEvent(). > (See : http://trac.webkit.org/browser/trunk/Source/WebCore/editing/Editor.cpp#L958 ) Got it. I had to look outside the patch to see that. r=me.
Comment on attachment 217273 [details] Patch Clearing flags on attachment: 217273 Committed r159544: <http://trac.webkit.org/changeset/159544>
All reviewed patches have been landed. Closing bug.