Upstream iOS's ResourceHandle implementation
Created attachment 217260 [details] Patch
Attachment 217260 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/platform/network/ResourceHandle.h', u'Source/WebCore/platform/network/ResourceHandleClient.h', u'Source/WebCore/platform/network/ResourceHandleInternal.h', u'Source/WebCore/platform/network/cf/ResourceHandleCFNet.cpp']" exit_code: 1 Source/WebCore/platform/network/ResourceHandle.h:38: CFURLConnectionClient_V6 is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 217260 [details] Patch Attachment 217260 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/28618041
Created attachment 217264 [details] Patch
Attachment 217264 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/platform/network/ResourceHandle.h', u'Source/WebCore/platform/network/ResourceHandleClient.h', u'Source/WebCore/platform/network/ResourceHandleInternal.h', u'Source/WebCore/platform/network/cf/ResourceHandleCFNet.cpp']" exit_code: 1 Source/WebCore/platform/network/ResourceHandle.h:75: CFURLConnectionClient_V6 is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
I did some basic cleaning to reduce the numbers of #ifdefs. I'll add the asynchronous implementation on top of this.
Comment on attachment 217264 [details] Patch Clearing flags on attachment: 217264 Committed r159479: <http://trac.webkit.org/changeset/159479>
All reviewed patches have been landed. Closing bug.
Comment on attachment 217264 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=217264&action=review Looks good! QuickLook integration at ResourceHandle level is a surprising place to see it. > Source/WebCore/platform/network/cf/ResourceHandleCFNet.cpp:394 > +#if PLATFORM(IOS) > + ProtectionSpace coreProtectionSpace = core(protectionSpace); > + if (coreProtectionSpace.authenticationScheme() == ProtectionSpaceAuthenticationSchemeUnknown) > + return false; > + return handle->canAuthenticateAgainstProtectionSpace(coreProtectionSpace); > +#else > return handle->canAuthenticateAgainstProtectionSpace(core(protectionSpace)); > +#endif This looks like it could be cross-platform maybe. Did you blame the iOS side to see what this fix was for? > Source/WebCore/platform/network/cf/ResourceHandleCFNet.cpp:881 > +CFURLConnectionClient_V6* ResourceHandle::connectionClientCallbacks() The result of this function is copied anyway, why not return a const object pointer?