Bug 124545 - ARM64 CRASH: Debug builds crash in emitPointerValidation()
Summary: ARM64 CRASH: Debug builds crash in emitPointerValidation()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Michael Saboff
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-18 16:09 PST by Michael Saboff
Modified: 2013-11-18 16:33 PST (History)
2 users (show)

See Also:


Attachments
Patch (1.45 KB, patch)
2013-11-18 16:25 PST, Michael Saboff
fpizlo: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Saboff 2013-11-18 16:09:23 PST
The function emitPointerValidation() uses push()/pop() in debug builds.  These aren't implemented in the ARM64 macro assembler.
Comment 1 Michael Saboff 2013-11-18 16:25:06 PST
Created attachment 217246 [details]
Patch
Comment 2 WebKit Commit Bot 2013-11-18 16:26:56 PST
Attachment 217246 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/jit/ThunkGenerators.cpp']" exit_code: 1
Source/JavaScriptCore/ChangeLog:8:  Line contains tab character.  [whitespace/tab] [5]
Source/JavaScriptCore/ChangeLog:9:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 2 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Geoffrey Garen 2013-11-18 16:27:45 PST
Comment on attachment 217246 [details]
Patch

> Source/JavaScriptCore/ChangeLog:10
> +        Reviewed by NOBODY (OOPS!).
> +
> +	Changed emitPointerValidation() to use pushToSave() and popToRestore() as
> +	all macro assemblers have an implementation of these functions.
> +

Please fix indentation.
Comment 4 Michael Saboff 2013-11-18 16:29:04 PST
(In reply to comment #3)
> (From update of attachment 217246 [details])
> > Source/JavaScriptCore/ChangeLog:10
> > +        Reviewed by NOBODY (OOPS!).
> > +
> > +	Changed emitPointerValidation() to use pushToSave() and popToRestore() as
> > +	all macro assemblers have an implementation of these functions.
> > +
> 
> Please fix indentation.

Done.  Still setting up a new machine.
Comment 5 Michael Saboff 2013-11-18 16:33:01 PST
Committed r159469: <http://trac.webkit.org/changeset/159469>