Bug 124544 – Web Inspector: Update WebInspectorUI to use the new "nodeIds" parameter for DOM.performSearch

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Alexandru Chiculita]

The search should be limited to just the view the user has open. In 124390 a new parameter has been added on the protocol to help with that. Make sure we are using the new parameter in the FrameDOMTreeContentView and ContentFlowDOMTreeContentView. This way the search results will be limited to just the elements visible in the current view.

[Alexandru Chiculita]

Created attachment 217245 [details]
Patch V1

[Joseph Pecoraro]

Comment on attachment 217245 [details]
Patch V1

View in context: https://bugs.webkit.org/attachment.cgi?id=217245&action=review

> Source/WebInspectorUI/UserInterface/DOMTreeContentView.js:215
> -        DOMAgent.performSearch(query, searchResultsReady.bind(this));
> +        function contextNodesReady(nodeIds)
> +        {
> +            DOMAgent.performSearch(query, nodeIds, searchResultsReady.bind(this));
> +        }

NOTE TO SELF: Adding an extra optional parameter like this does not break iOS 6 and 7 compatibility. So this is good.

This might even be a good comment to throw into the ChangeLog.

> Source/WebInspectorUI/UserInterface/DOMTreeContentView.js:224
> +        callback();

Nit: I would prefer to see callback(undefined) to more explicitly show we're passing undefined to performSearch.

[Alexandru Chiculita]

Created attachment 217252 [details]
Patch for landing

Thanks Joe!

[WebKit Commit Bot]

Comment on attachment 217252 [details]
Patch for landing

Clearing flags on attachment: 217252

Committed r159475: <http://trac.webkit.org/changeset/159475>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.