Bug 124540 - APIEntryShims need some love
Summary: APIEntryShims need some love
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Hahnenberg
URL:
Keywords:
Depends on: 124616
Blocks: 123195
  Show dependency treegraph
 
Reported: 2013-11-18 14:53 PST by Mark Hahnenberg
Modified: 2014-04-29 15:27 PDT (History)
1 user (show)

See Also:


Attachments
Patch (7.09 KB, patch)
2013-11-18 14:56 PST, Mark Hahnenberg
fpizlo: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Hahnenberg 2013-11-18 14:53:12 PST
We're missing them in key places which some other hacking revealed.
Comment 1 Mark Hahnenberg 2013-11-18 14:56:46 PST
Created attachment 217239 [details]
Patch
Comment 2 Mark Hahnenberg 2013-11-18 15:04:55 PST
Committed r159459: <http://trac.webkit.org/changeset/159459>
Comment 3 WebKit Commit Bot 2013-11-19 16:25:23 PST
Re-opened since this is blocked by bug 124616
Comment 4 Mark Hahnenberg 2014-04-29 15:27:25 PDT
APIEntryShim was replaced with JSLockHolder, which has since been put in most of the places APIEntryShim was missing.