Bug 124528 – Add PageLoadState class

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Anders Carlsson]

Add PageLoadState class

[Anders Carlsson]

Created attachment 217215 [details]
Patch

Comment on attachment 217215 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=217215&action=review

Looks OK.

> Source/WebKit2/ChangeLog:10
> +        Trying to use the main frame load state as the page load state was a bad idea,
> +        add a new PageLoadState and use it instead. Ultimately the long term plan is to
> +        transition away from FrameLoadState entirely.

FrameLoadState was just recently added? Should we revert those patches if they were steps in the wrong direction?

> Source/WebKit2/UIProcess/PageLoadState.h:41
> +private:
> +

Please remove this.

[EFL EWS Bot]

Comment on attachment 217215 [details]
Patch

Attachment 217215 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/25928075

[Anders Carlsson]

(In reply to comment #2)
> (From update of attachment 217215 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=217215&action=review
> 
> Looks OK.
> 
> > Source/WebKit2/ChangeLog:10
> > +        Trying to use the main frame load state as the page load state was a bad idea,
> > +        add a new PageLoadState and use it instead. Ultimately the long term plan is to
> > +        transition away from FrameLoadState entirely.
> 
> FrameLoadState was just recently added? Should we revert those patches if they were steps in the wrong direction?

I still think it’s worth abstracting the frame load state out into a separate object.

[Anders Carlsson]

Committed r159444: <http://trac.webkit.org/changeset/159444>