Add PageLoadState class
Created attachment 217215 [details] Patch
Comment on attachment 217215 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=217215&action=review Looks OK. > Source/WebKit2/ChangeLog:10 > + Trying to use the main frame load state as the page load state was a bad idea, > + add a new PageLoadState and use it instead. Ultimately the long term plan is to > + transition away from FrameLoadState entirely. FrameLoadState was just recently added? Should we revert those patches if they were steps in the wrong direction? > Source/WebKit2/UIProcess/PageLoadState.h:41 > +private: > + Please remove this.
Comment on attachment 217215 [details] Patch Attachment 217215 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/25928075
(In reply to comment #2) > (From update of attachment 217215 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=217215&action=review > > Looks OK. > > > Source/WebKit2/ChangeLog:10 > > + Trying to use the main frame load state as the page load state was a bad idea, > > + add a new PageLoadState and use it instead. Ultimately the long term plan is to > > + transition away from FrameLoadState entirely. > > FrameLoadState was just recently added? Should we revert those patches if they were steps in the wrong direction? I still think itβs worth abstracting the frame load state out into a separate object.
Committed r159444: <http://trac.webkit.org/changeset/159444>