Bug 124522 - Add quirk for old positioning behavior
Summary: Add quirk for old positioning behavior
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dave Hyatt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-18 10:39 PST by Dave Hyatt
Modified: 2013-11-18 15:06 PST (History)
4 users (show)

See Also:

Attachments
Patch (8.51 KB, patch)
2013-11-18 10:39 PST, Dave Hyatt 		simon.fraser: review+
Details | Formatted Diff | Diff
Patch (13.65 KB, patch)
2013-11-18 13:19 PST, Dave Hyatt 		simon.fraser: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Hyatt 2013-11-18 10:39:00 PST 
Add quirk for old text-align positioning behavior
Comment 1 Dave Hyatt 2013-11-18 10:39:16 PST 
Created attachment 217209 [details]
Patch
Comment 2 WebKit Commit Bot 2013-11-18 10:40:43 PST 
Attachment 217209 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast/block/legacy-text-align-position-quirk-expected.html', u'LayoutTests/fast/block/legacy-text-align-position-quirk.html', u'Source/WebCore/ChangeLog', u'Source/WebCore/page/Settings.in', u'Source/WebCore/rendering/RenderBlockLineLayout.cpp', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/Shared/WebPreferencesStore.h', u'Source/WebKit2/UIProcess/API/C/WKPreferences.cpp', u'Source/WebKit2/UIProcess/API/C/WKPreferences.h', u'Source/WebKit2/WebProcess/WebPage/WebPage.cpp']" exit_code: 1
Source/WebKit2/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
LayoutTests/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Source/WebCore/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 3 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Simon Fraser (smfr) 2013-11-18 10:43:14 PST 
Comment on attachment 217209 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=217209&action=review

> Source/WebCore/ChangeLog:8
> +        Need a short description (OOPS!).
> +        Need the bug URL (OOPS!).
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        No new tests (OOPS!).

OOPS!

> Source/WebCore/rendering/RenderBlockLineLayout.cpp:2269
> +    if (textAlign == TASTART || document().settings()->useLegacyTextAlignPositionedElementBehavior()) // FIXME: Handle TAEND here

Please add a comment referencing a bug here, so we know sometime in future whether we can remove it, and possibly stating the last Safari version that shipped with the legacy behavior.
Comment 4 Dave Hyatt 2013-11-18 11:25:58 PST 
(In reply to comment #3)
> (From update of attachment 217209 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=217209&action=review
> 
> > Source/WebCore/ChangeLog:8
> > +        Need a short description (OOPS!).
> > +        Need the bug URL (OOPS!).
> > +
> > +        Reviewed by NOBODY (OOPS!).
> > +
> > +        No new tests (OOPS!).
> 
> OOPS!
> 
> > Source/WebCore/rendering/RenderBlockLineLayout.cpp:2269
> > +    if (textAlign == TASTART || document().settings()->useLegacyTextAlignPositionedElementBehavior()) // FIXME: Handle TAEND here
> 
> Please add a comment referencing a bug here, so we know sometime in future whether we can remove it, and possibly stating the last Safari version that shipped with the legacy behavior.

This wasn't actually flagged for review, but ok, I'll take it. :)
Comment 5 Dave Hyatt 2013-11-18 13:19:55 PST 
Created attachment 217228 [details]
Patch
Comment 6 Dave Hyatt 2013-11-18 15:06:15 PST 
Fixed in r159460.