Bug 124522 – Add quirk for old positioning behavior

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Dave Hyatt]

Add quirk for old text-align positioning behavior

[Dave Hyatt]

Created attachment 217209 [details]
Patch

[WebKit Commit Bot]

Attachment 217209 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast/block/legacy-text-align-position-quirk-expected.html', u'LayoutTests/fast/block/legacy-text-align-position-quirk.html', u'Source/WebCore/ChangeLog', u'Source/WebCore/page/Settings.in', u'Source/WebCore/rendering/RenderBlockLineLayout.cpp', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/Shared/WebPreferencesStore.h', u'Source/WebKit2/UIProcess/API/C/WKPreferences.cpp', u'Source/WebKit2/UIProcess/API/C/WKPreferences.h', u'Source/WebKit2/WebProcess/WebPage/WebPage.cpp']" exit_code: 1
Source/WebKit2/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
LayoutTests/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Source/WebCore/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 3 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Simon Fraser (smfr)]

Comment on attachment 217209 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=217209&action=review

> Source/WebCore/ChangeLog:8
> +        Need a short description (OOPS!).
> +        Need the bug URL (OOPS!).
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        No new tests (OOPS!).

OOPS!

> Source/WebCore/rendering/RenderBlockLineLayout.cpp:2269
> +    if (textAlign == TASTART || document().settings()->useLegacyTextAlignPositionedElementBehavior()) // FIXME: Handle TAEND here

Please add a comment referencing a bug here, so we know sometime in future whether we can remove it, and possibly stating the last Safari version that shipped with the legacy behavior.

[Dave Hyatt]

(In reply to comment #3)
> (From update of attachment 217209 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=217209&action=review
> 
> > Source/WebCore/ChangeLog:8
> > +        Need a short description (OOPS!).
> > +        Need the bug URL (OOPS!).
> > +
> > +        Reviewed by NOBODY (OOPS!).
> > +
> > +        No new tests (OOPS!).
> 
> OOPS!
> 
> > Source/WebCore/rendering/RenderBlockLineLayout.cpp:2269
> > +    if (textAlign == TASTART || document().settings()->useLegacyTextAlignPositionedElementBehavior()) // FIXME: Handle TAEND here
> 
> Please add a comment referencing a bug here, so we know sometime in future whether we can remove it, and possibly stating the last Safari version that shipped with the legacy behavior.

This wasn't actually flagged for review, but ok, I'll take it. :)

[Dave Hyatt]

Created attachment 217228 [details]
Patch

[Dave Hyatt]

Fixed in r159460.