Bug 124520 - ARM64: Update getHostCallReturnValue() to use architected frame pointer register
Summary: ARM64: Update getHostCallReturnValue() to use architected frame pointer register
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Michael Saboff
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-18 10:27 PST by Michael Saboff
Modified: 2013-11-18 16:06 PST (History)
1 user (show)

See Also:

Attachments
Patch (1.42 KB, patch)
2013-11-18 10:35 PST, Michael Saboff 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Saboff 2013-11-18 10:27:49 PST 
The ARM64 changes for getHostCallReturnValue() as part of https://bugs.webkit.org/show_bug.cgi?id=123956 - "Change CallFrameRegister to architected frame pointer register" were not done.
Comment 1 Michael Saboff 2013-11-18 10:35:35 PST 
Created attachment 217208 [details]
Patch
Comment 2 WebKit Commit Bot 2013-11-18 10:37:51 PST 
Attachment 217208 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/jit/JITOperations.cpp']" exit_code: 1
Source/JavaScriptCore/jit/JITOperations.cpp:1770:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Michael Saboff 2013-11-18 16:05:41 PST 
Committed r159466: <http://trac.webkit.org/changeset/159466>
Comment 4 Michael Saboff 2013-11-18 16:06:48 PST 
Comment on attachment 217208 [details]
Patch

Reviewed in person.