Bug 124495 - [Performance tests] Interactive/SelectAll.html throws an exception
Summary: [Performance tests] Interactive/SelectAll.html throws an exception
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks: 124496
  Show dependency tree / graph
 
Reported: 2013-11-18 04:55 PST by Ryosuke Niwa
Modified: 2013-11-18 07:26 PST (History)
5 users (show)

See Also:

Attachments
Fixes the bug (2.59 KB, patch)
2013-11-18 05:00 PST, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Added Reviewed by line (2.63 KB, patch)
2013-11-18 05:02 PST, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2013-11-18 04:55:59 PST 
Interactive/SelectAll.html throws an exception because runTest doesn't stop gracefully after reaching 20 iterations.

Return a boolean indicating whether more values are needed or not in PerfTestRunner.measureValueAsync to fix this bug.
Comment 1 Ryosuke Niwa 2013-11-18 05:00:51 PST 
Created attachment 217190 [details]
Fixes the bug
Comment 2 Ryosuke Niwa 2013-11-18 05:02:44 PST 
Created attachment 217191 [details]
Added Reviewed by line
Comment 3 WebKit Commit Bot 2013-11-18 07:26:28 PST 
Comment on attachment 217191 [details]
Added Reviewed by line

Clearing flags on attachment: 217191

Committed r159421: <http://trac.webkit.org/changeset/159421>
Comment 4 WebKit Commit Bot 2013-11-18 07:26:30 PST 
All reviewed patches have been landed.  Closing bug.