Bug 124468 - [sh4] revertJumpReplacementToBranchPtrWithPatch implementation is wrong in MacroAssembler
Summary: [sh4] revertJumpReplacementToBranchPtrWithPatch implementation is wrong in Ma...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-17 08:45 PST by Julien Brianceau
Modified: 2013-11-17 23:49 PST (History)
5 users (show)

See Also:

Attachments
Fix revertJumpReplacementToBranchPtrWithPatch implementation in MacroAssembler for sh4. (5.31 KB, patch)
2013-11-17 09:39 PST, Julien Brianceau 		msaboff: review+
Details | Formatted Diff | Diff
Fix revertJumpReplacementToBranchPtrWithPatch implementation in MacroAssembler for sh4 (2). (5.31 KB, patch)
2013-11-17 23:10 PST, Julien Brianceau 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Julien Brianceau 2013-11-17 08:45:58 PST 
Current implementation of revertJumpReplacementToBranchPtrWithPatch is wrong in the sh4 MacroAssembler part, leading to random unstabilities with this architecture.

I'll submit a patch soon to fix this.
Comment 1 Julien Brianceau 2013-11-17 09:39:48 PST 
Created attachment 217150 [details]
Fix revertJumpReplacementToBranchPtrWithPatch implementation in MacroAssembler for sh4.
Comment 2 Michael Saboff 2013-11-17 16:37:45 PST 
Comment on attachment 217150 [details]
Fix revertJumpReplacementToBranchPtrWithPatch implementation in MacroAssembler for sh4.

View in context: https://bugs.webkit.org/attachment.cgi?id=217150&action=review

> Source/JavaScriptCore/ChangeLog:9
> +        the sh4 MacroAssembler part, leading to random unstabilities. This patch fixes it

I think you mean "instabilities".
Comment 3 Julien Brianceau 2013-11-17 23:09:47 PST 
(In reply to comment #2)
> I think you mean "instabilities".
Indeed :)
Comment 4 Julien Brianceau 2013-11-17 23:10:25 PST 
Created attachment 217170 [details]
 Fix revertJumpReplacementToBranchPtrWithPatch implementation in MacroAssembler for sh4 (2).
Comment 5 WebKit Commit Bot 2013-11-17 23:49:10 PST 
Comment on attachment 217170 [details]
 Fix revertJumpReplacementToBranchPtrWithPatch implementation in MacroAssembler for sh4 (2).

Clearing flags on attachment: 217170

Committed r159400: <http://trac.webkit.org/changeset/159400>
Comment 6 WebKit Commit Bot 2013-11-17 23:49:12 PST 
All reviewed patches have been landed.  Closing bug.