WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
124468
[sh4] revertJumpReplacementToBranchPtrWithPatch implementation is wrong in MacroAssembler
https://bugs.webkit.org/show_bug.cgi?id=124468
Summary
[sh4] revertJumpReplacementToBranchPtrWithPatch implementation is wrong in Ma...
Julien Brianceau
Reported
2013-11-17 08:45:58 PST
Current implementation of revertJumpReplacementToBranchPtrWithPatch is wrong in the sh4 MacroAssembler part, leading to random unstabilities with this architecture. I'll submit a patch soon to fix this.
Attachments
Fix revertJumpReplacementToBranchPtrWithPatch implementation in MacroAssembler for sh4.
(5.31 KB, patch)
2013-11-17 09:39 PST
,
Julien Brianceau
msaboff
: review+
Details
Formatted Diff
Diff
Fix revertJumpReplacementToBranchPtrWithPatch implementation in MacroAssembler for sh4 (2).
(5.31 KB, patch)
2013-11-17 23:10 PST
,
Julien Brianceau
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Julien Brianceau
Comment 1
2013-11-17 09:39:48 PST
Created
attachment 217150
[details]
Fix revertJumpReplacementToBranchPtrWithPatch implementation in MacroAssembler for sh4.
Michael Saboff
Comment 2
2013-11-17 16:37:45 PST
Comment on
attachment 217150
[details]
Fix revertJumpReplacementToBranchPtrWithPatch implementation in MacroAssembler for sh4. View in context:
https://bugs.webkit.org/attachment.cgi?id=217150&action=review
> Source/JavaScriptCore/ChangeLog:9 > + the sh4 MacroAssembler part, leading to random unstabilities. This patch fixes it
I think you mean "instabilities".
Julien Brianceau
Comment 3
2013-11-17 23:09:47 PST
(In reply to
comment #2
)
> I think you mean "instabilities".
Indeed :)
Julien Brianceau
Comment 4
2013-11-17 23:10:25 PST
Created
attachment 217170
[details]
Fix revertJumpReplacementToBranchPtrWithPatch implementation in MacroAssembler for sh4 (2).
WebKit Commit Bot
Comment 5
2013-11-17 23:49:10 PST
Comment on
attachment 217170
[details]
Fix revertJumpReplacementToBranchPtrWithPatch implementation in MacroAssembler for sh4 (2). Clearing flags on attachment: 217170 Committed
r159400
: <
http://trac.webkit.org/changeset/159400
>
WebKit Commit Bot
Comment 6
2013-11-17 23:49:12 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug