Bug 124463 - Move execution of IDBCursorBackendOperations to the IDBServerConnection
Summary: Move execution of IDBCursorBackendOperations to the IDBServerConnection
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-16 16:01 PST by Brady Eidson
Modified: 2013-11-18 11:59 PST (History)
4 users (show)

See Also:


Attachments
Patch v1 (65.85 KB, patch)
2013-11-16 16:04 PST, Brady Eidson
thorton: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2013-11-16 16:01:31 PST
Move execution of IDBCursorBackendOperations to the IDBServerConnection

This almost entirely removes knowledge of the backing store from the front end.
Comment 1 Brady Eidson 2013-11-16 16:04:03 PST
Created attachment 217139 [details]
Patch v1
Comment 2 Tim Horton 2013-11-18 11:52:57 PST
Comment on attachment 217139 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=217139&action=review

I was once (recently) made to typedef my IDs :(

> Source/WebCore/Modules/indexeddb/IDBCursorBackend.h:75
> +    void clearCursorData();

given the class name, I wonder if the CursorData suffix is necessary here (and maybe elsewhere)

> Source/WebCore/Modules/indexeddb/IDBCursorBackend.h:87
> +    int64_t m_cursorID; // Must be destroyed before m_transaction.
> +    int64_t m_savedCursorID; // Must be destroyed before m_transaction.

Destroying int64_ts?
Comment 3 Brady Eidson 2013-11-18 11:59:20 PST
http://trac.webkit.org/changeset/159445