Bug 124455 - [sh4] Build is broken since r159346
Summary: [sh4] Build is broken since r159346
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-16 09:08 PST by Julien Brianceau
Modified: 2013-11-16 14:26 PST (History)
5 users (show)

See Also:

Attachments
Handle load and store operations with pr register in sh4 LLINT. (2.82 KB, patch)
2013-11-16 09:24 PST, Julien Brianceau 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Julien Brianceau 2013-11-16 09:08:30 PST 
r159346 introduced the following instruciton in LowLevelInterpreter32_64.asm

    storep previousPC, 4[newCallFrame] 

which is translated into the following invalid assembly for sh4:

    mov.l pr, @(4, r5)
Comment 1 Julien Brianceau 2013-11-16 09:24:45 PST 
Created attachment 217126 [details]
Handle load and store operations with pr register in sh4 LLINT.

This patch fixes the build. The above code is now generated using a temp register:

    sts pr, r13
    mov.l r13, @(4, r5)
Comment 2 WebKit Commit Bot 2013-11-16 14:26:11 PST 
Comment on attachment 217126 [details]
Handle load and store operations with pr register in sh4 LLINT.

Clearing flags on attachment: 217126

Committed r159381: <http://trac.webkit.org/changeset/159381>
Comment 3 WebKit Commit Bot 2013-11-16 14:26:13 PST 
All reviewed patches have been landed.  Closing bug.