Bug 124444 - Move IDBCursorBackend operations into their own files
Summary: Move IDBCursorBackend operations into their own files
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-15 17:00 PST by Brady Eidson
Modified: 2013-11-15 17:14 PST (History)
5 users (show)

See Also:

Attachments
Patch v1 (25.06 KB, patch)
2013-11-15 17:01 PST, Brady Eidson 		thorton: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2013-11-15 17:00:02 PST 
Move IDBCursorBackend operations into their own files
Comment 1 Brady Eidson 2013-11-15 17:01:15 PST 
Created attachment 217104 [details]
Patch v1
Comment 2 Brady Eidson 2013-11-15 17:03:18 PST 
Style bot will complain about IDBCursorBackendOperations.h and IDBCursorBackendOperations.cpp not having newlines at the end.  Fixed locally.
Comment 3 WebKit Commit Bot 2013-11-15 17:03:33 PST 
Attachment 217104 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/Modules/indexeddb/IDBCursorBackend.cpp', u'Source/WebCore/Modules/indexeddb/IDBCursorBackend.h', u'Source/WebCore/Modules/indexeddb/IDBCursorBackendOperations.cpp', u'Source/WebCore/Modules/indexeddb/IDBCursorBackendOperations.h', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj']" exit_code: 1
Source/WebCore/Modules/indexeddb/IDBCursorBackendOperations.h:102:  Could not find a newline character at the end of the file.  [whitespace/ending_newline] [5]
Source/WebCore/Modules/indexeddb/IDBCursorBackendOperations.cpp:131:  Could not find a newline character at the end of the file.  [whitespace/ending_newline] [5]
Source/WebCore/CMakeLists.txt:792:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 3 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Brady Eidson 2013-11-15 17:04:35 PST 
(In reply to comment #3)
> Attachment 217104 [details] did not pass style-queue:
> Source/WebCore/CMakeLists.txt:792:  Line contains tab character.  [whitespace/tab] [5]

Fixed that, too.
Comment 5 Tim Horton 2013-11-15 17:09:34 PST 
Comment on attachment 217104 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=217104&action=review

> Source/WebCore/Modules/indexeddb/IDBCursorBackendOperations.cpp:2
> + * Copyright (C) 2013 Apple Inc. All rights reserved.

Please use the license header from the original file.
Comment 6 Brady Eidson 2013-11-15 17:14:31 PST 
http://trac.webkit.org/changeset/159373