Bug 124431 – Give the policy client the originating frame of a navigation action

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

For link activations and form submissions, the frame being navigated is not necessarily the frame where the navigation action occurred. Give the policy delegate access to the latter as well.

Created attachment 217075 [details]
Add originatingFrame to decidePolicyForNavigationAction

[WebKit Commit Bot]

Attachment 217075 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/Platform/CoreIPC/HandleMessage.h', u'Source/WebKit2/Shared/APIClientTraits.cpp', u'Source/WebKit2/Shared/APIClientTraits.h', u'Source/WebKit2/UIProcess/API/C/WKPage.h', u'Source/WebKit2/UIProcess/API/mac/WKBrowsingContextController.mm', u'Source/WebKit2/UIProcess/API/mac/WKBrowsingContextPolicyDelegate.h', u'Source/WebKit2/UIProcess/WebInspectorProxy.cpp', u'Source/WebKit2/UIProcess/WebPageProxy.cpp', u'Source/WebKit2/UIProcess/WebPageProxy.h', u'Source/WebKit2/UIProcess/WebPageProxy.messages.in', u'Source/WebKit2/UIProcess/WebPolicyClient.cpp', u'Source/WebKit2/UIProcess/WebPolicyClient.h', u'Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp', u'Tools/ChangeLog', u'Tools/MiniBrowser/mac/WK2BrowserWindowController.m', u'Tools/TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp', u'Tools/TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp', u'Tools/WebKitTestRunner/TestController.cpp', u'Tools/WebKitTestRunner/TestController.h']" exit_code: 1
Source/WebKit2/UIProcess/API/mac/WKBrowsingContextPolicyDelegate.h:31:  One space before end of line comments  [whitespace/comments] [5]
Source/WebKit2/UIProcess/API/mac/WKBrowsingContextPolicyDelegate.h:32:  One space before end of line comments  [whitespace/comments] [5]
Source/WebKit2/UIProcess/API/mac/WKBrowsingContextPolicyDelegate.h:33:  One space before end of line comments  [whitespace/comments] [5]
Source/WebKit2/UIProcess/API/mac/WKBrowsingContextPolicyDelegate.h:34:  One space before end of line comments  [whitespace/comments] [5]
Source/WebKit2/UIProcess/API/mac/WKBrowsingContextPolicyDelegate.h:35:  One space before end of line comments  [whitespace/comments] [5]
Source/WebKit2/UIProcess/API/mac/WKBrowsingContextPolicyDelegate.h:36:  One space before end of line comments  [whitespace/comments] [5]
Source/WebKit2/UIProcess/API/mac/WKBrowsingContextPolicyDelegate.h:37:  One space before end of line comments  [whitespace/comments] [5]
Total errors found: 7 in 20 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment on attachment 217075 [details]
Add originatingFrame to decidePolicyForNavigationAction

Actually, we want this in the new window policy callback as well. Updated patch forthcoming.

Comment on attachment 217075 [details]
Add originatingFrame to decidePolicyForNavigationAction

On second thought, for the new window policy, the originating frame is the frame we already have.

Committed <http://trac.webkit.org/r159358>.