Bug 124429 - Web Inspector: Add TreeOutlineDataGridSynchronizer to coordinate sidebar and content views
Summary: Web Inspector: Add TreeOutlineDataGridSynchronizer to coordinate sidebar and ...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Timothy Hatcher
Keywords: InRadar
Depends on:
Reported: 2013-11-15 12:25 PST by Timothy Hatcher
Modified: 2014-01-20 19:01 PST (History)
4 users (show)

See Also:

Patch (26.99 KB, patch)
2013-11-15 12:37 PST, Timothy Hatcher
joepeck: review+
timothy: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2013-11-15 12:25:53 PST
The TreeOutlineDataGridSynchronizer will help manage a TreeOutline in the sidebar and DataGrid in the content view.
Comment 1 Radar WebKit Bug Importer 2013-11-15 12:26:39 PST
Comment 2 Timothy Hatcher 2013-11-15 12:37:17 PST
Created attachment 217070 [details]
Comment 3 Joseph Pecoraro 2013-11-18 10:23:11 PST
Comment on attachment 217070 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=217070&action=review


> Source/WebInspectorUI/UserInterface/TreeOutlineDataGridSynchronizer.js:60
> +    treeOutline.onremove = function(element) {
> +        this._treeElementRemoved(element);
> +        if (existingOnRemove)
> +            existingOnRemove.call(treeOutline, element);
> +    }.bind(this);

Based on the naming for all of these, I would expect the "this.method" to be called after the existing TreeOutline method. But no strong reason to change now.
Comment 4 Timothy Hatcher 2014-01-20 19:01:47 PST