Bug 124428 - [CSS Shapes] Layout using [<box> || <shape>] value
Summary: [CSS Shapes] Layout using [<box> || <shape>] value
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Bear Travis
URL:
Keywords:
Depends on: 124426
Blocks: 124173
  Show dependency tree / graph
 
Reported: 2013-11-15 12:00 PST by Bear Travis
Modified: 2013-11-26 15:02 PST (History)
10 users (show)

See Also:

Attachments
Initial Patch (56.42 KB, patch)
2013-11-20 16:04 PST, Bear Travis 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2 (457.07 KB, application/zip)
2013-11-20 17:08 PST, Build Bot 		no flags Details
Fixing inspector test (57.66 KB, patch)
2013-11-20 17:43 PST, Bear Travis 		no flags Details | Formatted Diff | Diff
Updated patch (57.67 KB, patch)
2013-11-21 11:26 PST, Bear Travis 		hyatt: review+
Details | Formatted Diff | Diff
Updating patch (54.72 KB, patch)
2013-11-26 13:37 PST, Bear Travis 		commit-queue: commit-queue-
Details | Formatted Diff | Diff
Fixing reviewer (54.82 KB, patch)
2013-11-26 14:31 PST, Bear Travis 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Bear Travis 2013-11-15 12:00:34 PST 
The box value, if supplied, modified the coordinate system for the shape. See
http://dev.w3.org/csswg/css-shapes/#shape-outside-property
Comment 1 Bear Travis 2013-11-20 16:04:54 PST 
Created attachment 217491 [details]
Initial Patch
Comment 2 Build Bot 2013-11-20 17:08:52 PST 
Comment on attachment 217491 [details]
Initial Patch

Attachment 217491 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/30628019

New failing tests:
inspector-protocol/model/highlight-shape-outside.html
Comment 3 Build Bot 2013-11-20 17:08:54 PST 
Created attachment 217500 [details]
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-14  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 4 Bear Travis 2013-11-20 17:43:32 PST 
Created attachment 217505 [details]
Fixing inspector test
Comment 5 Bear Travis 2013-11-21 11:26:47 PST 
Created attachment 217585 [details]
Updated patch
Comment 6 Dave Hyatt 2013-11-26 10:16:30 PST 
Comment on attachment 217585 [details]
Updated patch

r=me
Comment 7 WebKit Commit Bot 2013-11-26 10:20:38 PST 
Comment on attachment 217585 [details]
Updated patch

Rejecting attachment 217585 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 217585, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
e-outside-shape-boxes-002.html
patching file LayoutTests/fast/shapes/shape-outside-floats/shape-outside-shape-boxes-003-expected.html
patching file LayoutTests/fast/shapes/shape-outside-floats/shape-outside-shape-boxes-003.html
patching file LayoutTests/inspector-protocol/model/highlight-shape-outside.html
Hunk #1 succeeded at 25 with fuzz 2.

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'David Hyatt']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.appspot.com/results/37208112
Comment 8 Bear Travis 2013-11-26 13:37:59 PST 
Created attachment 217897 [details]
Updating patch
Comment 9 WebKit Commit Bot 2013-11-26 13:39:27 PST 
Comment on attachment 217897 [details]
Updating patch

Rejecting attachment 217897 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 217897, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Dave Hyatt found in /Volumes/Data/EWS/WebKit/LayoutTests/ChangeLog does not appear to be a valid reviewer according to contributors.json.
/Volumes/Data/EWS/WebKit/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://webkit-queues.appspot.com/results/37468029
Comment 10 Bear Travis 2013-11-26 14:31:08 PST 
Created attachment 217901 [details]
Fixing reviewer
Comment 11 WebKit Commit Bot 2013-11-26 15:02:54 PST 
Comment on attachment 217901 [details]
Fixing reviewer

Clearing flags on attachment: 217901

Committed r159792: <http://trac.webkit.org/changeset/159792>
Comment 12 WebKit Commit Bot 2013-11-26 15:02:58 PST 
All reviewed patches have been landed.  Closing bug.