Bug 124420 - REGRESSION (r158586): callToJavaScript needs to save return PC to Sentinel frame
Summary: REGRESSION (r158586): callToJavaScript needs to save return PC to Sentinel frame
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Michael Saboff
URL:
Keywords:
Depends on:
Blocks: 116888
  Show dependency tree / graph
 
Reported: 2013-11-15 10:08 PST by Michael Saboff
Modified: 2013-11-15 11:04 PST (History)
0 users

See Also:

Attachments
Patch (4.95 KB, patch)
2013-11-15 10:42 PST, Michael Saboff 		fpizlo: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Saboff 2013-11-15 10:08:28 PST 
The sentinel frame added in r158586 sets the return PC in the sentinel frame to 0.  The sentinel frame is effectively the call frame for callToJavaScript and therefore should have the return PC set to its caller.
Comment 1 Michael Saboff 2013-11-15 10:42:11 PST 
Created attachment 217063 [details]
Patch
Comment 2 Michael Saboff 2013-11-15 11:04:52 PST 
Committed r159346: <http://trac.webkit.org/changeset/159346>