Bug 124416 - [CSS Shapes] Refactor RectangleShape
Summary: [CSS Shapes] Refactor RectangleShape
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 124368
  Show dependency treegraph
 
Reported: 2013-11-15 09:29 PST by Hans Muller
Modified: 2013-11-19 12:13 PST (History)
5 users (show)

See Also:


Attachments
Patch (8.60 KB, patch)
2013-11-15 10:47 PST, Hans Muller
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hans Muller 2013-11-15 09:29:43 PST
Currently RectangleShape includes a FloatRoundedRect class which is effectively private.  To make way for a public FloatRoundedRect class, which will be the basis for both RectangleShape and TBD BoxShape, the existing FloatRoundedRect class should be renamed and made private to RectangleShape.
Comment 1 Hans Muller 2013-11-15 10:47:28 PST
Created attachment 217064 [details]
Patch

Privatize and rename the FloatRoundedRect class defined in RectangleShape.h. The new class is called RectangleShape::ShapeBounds. This change enables creating a proper FloatRoundedRect analog of the existing RoundedRect class; part of adding support for box shapes, per the latest CSS spec (see https://bugs.webkit.org/show_bug.cgi?id=124368).
Comment 2 WebKit Commit Bot 2013-11-19 12:13:18 PST
Comment on attachment 217064 [details]
Patch

Clearing flags on attachment: 217064

Committed r159513: <http://trac.webkit.org/changeset/159513>
Comment 3 WebKit Commit Bot 2013-11-19 12:13:20 PST
All reviewed patches have been landed.  Closing bug.