RESOLVED FIXED 124404
[AX] Use std::unique_ptr to manage AXComputedObjectAttributeCache
https://bugs.webkit.org/show_bug.cgi?id=124404
Summary [AX] Use std::unique_ptr to manage AXComputedObjectAttributeCache
Krzysztof Czech
Reported 2013-11-15 03:56:57 PST
Convert OwnPtr/PassOwnPtr to std::unique_ptr.
Attachments
proposed patch (2.96 KB, patch)
2013-11-15 03:59 PST, Krzysztof Czech
no flags
Radar WebKit Bug Importer
Comment 1 2013-11-15 03:57:13 PST
Krzysztof Czech
Comment 2 2013-11-15 03:59:23 PST
Created attachment 217040 [details] proposed patch
Mario Sanchez Prada
Comment 3 2013-11-18 03:25:54 PST
Comment on attachment 217040 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=217040&action=review > Source/WebCore/accessibility/AXObjectCache.h:-64 > - AXComputedObjectAttributeCache() { } > - Instead of just removing the constructor from the private section to make it public (so you can use it with make_unique), I think you'd better move this constructor to the public section and add the explicit keyword there to make it, well, explicit :)
Krzysztof Czech
Comment 4 2013-11-18 08:23:34 PST
(In reply to comment #3) > (From update of attachment 217040 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=217040&action=review > > > Source/WebCore/accessibility/AXObjectCache.h:-64 > > - AXComputedObjectAttributeCache() { } > > - > > Instead of just removing the constructor from the private section to make it public (so you can use it with make_unique), I think you'd better move this constructor to the public section and add the explicit keyword there to make it, well, explicit :) I'm thinking about any benefits of moving to public and declaring AXComputedObjectAttributeCache() { } as a explicit. I guess there won't be any implicit conversions. It's a constructor without parameters.
Krzysztof Czech
Comment 5 2013-11-19 05:59:39 PST
Any more comments on this ?
Mario Sanchez Prada
Comment 6 2013-11-19 06:28:32 PST
Comment on attachment 217040 [details] proposed patch (In reply to comment #5) > Any more comments on this ? Nope. I think it's ok like it is then, unless I'm missing something.
WebKit Commit Bot
Comment 7 2013-11-19 06:53:12 PST
Comment on attachment 217040 [details] proposed patch Clearing flags on attachment: 217040 Committed r159500: <http://trac.webkit.org/changeset/159500>
WebKit Commit Bot
Comment 8 2013-11-19 06:53:14 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.