Bug 124404 – [AX] Use std::unique_ptr to manage AXComputedObjectAttributeCache

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[Krzysztof Czech]

Convert OwnPtr/PassOwnPtr to std::unique_ptr.

[Radar WebKit Bug Importer]

<rdar://problem/15479102>

[Krzysztof Czech]

Created attachment 217040 [details]
proposed patch

[Mario Sanchez Prada]

Comment on attachment 217040 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=217040&action=review

> Source/WebCore/accessibility/AXObjectCache.h:-64
> -    AXComputedObjectAttributeCache() { }
> -

Instead of just removing the constructor from the private section to make it public (so you can use it with make_unique), I think you'd better move this constructor to the public section and add the explicit keyword there to make it, well, explicit :)

[Krzysztof Czech]

(In reply to comment #3)
> (From update of attachment 217040 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=217040&action=review
> 
> > Source/WebCore/accessibility/AXObjectCache.h:-64
> > -    AXComputedObjectAttributeCache() { }
> > -
> 
> Instead of just removing the constructor from the private section to make it public (so you can use it with make_unique), I think you'd better move this constructor to the public section and add the explicit keyword there to make it, well, explicit :)

I'm thinking about any benefits of moving to public and declaring AXComputedObjectAttributeCache() { } as a explicit. I guess there won't be any implicit conversions. It's a constructor without parameters.

[Krzysztof Czech]

Any more comments on this ?

[Mario Sanchez Prada]

Comment on attachment 217040 [details]
proposed patch

(In reply to comment #5)
> Any more comments on this ?

Nope. I think it's ok like it is then, unless I'm missing something.

[WebKit Commit Bot]

Comment on attachment 217040 [details]
proposed patch

Clearing flags on attachment: 217040

Committed r159500: <http://trac.webkit.org/changeset/159500>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.