Bug 124401 – [EFL] Leak in ewk_frame_certificate_status_get()

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Alberto Garcia]

I just stumbled upon this piece of code in ewk_frame.cpp:

   SoupMessage* soupMessage = documentLoader->request().toSoupMessage();

That object is not being freed.

[Alberto Garcia]

Created attachment 217030 [details]
Patch

Here's the patch, it should work fine but note that I don't have a working WebKitEFL environment here to test it.

[EFL EWS Bot]

Comment on attachment 217030 [details]
Patch

Attachment 217030 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/23968033

[Alberto Garcia]

Created attachment 217033 [details]
Patch

Right, here's a new version.

[Carlos Garcia Campos]

Comment on attachment 217033 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=217033&action=review

> Source/WebKit/efl/ewk/ewk_frame.cpp:1705
> -    SoupMessage* soupMessage = documentLoader->request().toSoupMessage();
> +    GRefPtr<SoupMessage> soupMessage(adoptGRef(documentLoader->request().toSoupMessage()));
>  
> -    if (soupMessage && (soup_message_get_flags(soupMessage) & SOUP_MESSAGE_CERTIFICATE_TRUSTED))
> +    if (soupMessage && (soup_message_get_flags(soupMessage.get()) & SOUP_MESSAGE_CERTIFICATE_TRUSTED))

I think you could even avoid to create the soup message object by simply using 

if (documentLoader->request().soupMessageFlags() & SOUP_MESSAGE_CERTIFICATE_TRUSTED)

[Alberto Garcia]

Created attachment 217043 [details]
Patch

(In reply to comment #4)
> I think you could even avoid to create the soup message object by simply using
>
> if (documentLoader->request().soupMessageFlags() & SOUP_MESSAGE_CERTIFICATE_TRUSTED)

Good point, here's the new patch.

[Chris Dumez]

Comment on attachment 217043 [details]
Patch

LGTM

[Alberto Garcia]

Committed r159334: <http://trac.webkit.org/changeset/159334>