Bug 124390 - Web Inspector: DOM.performSearch should accept a list of context nodes
Summary: Web Inspector: DOM.performSearch should accept a list of context nodes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Alexandru Chiculita
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-11-14 18:19 PST by Alexandru Chiculita
Modified: 2013-11-15 14:06 PST (History)
7 users (show)

See Also:

Attachments
Patch V1 (51.54 KB, patch)
2013-11-14 18:30 PST, Alexandru Chiculita 		timothy: review+
Details | Formatted Diff | Diff
Patch for landing (51.63 KB, patch)
2013-11-15 13:33 PST, Alexandru Chiculita 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexandru Chiculita 2013-11-14 18:19:13 PST 
DOM.performSearch is currently searching through all the documents in a frame tree. However, the new inspector needs to search just through the current open document.

Add a new parameter that can limit the search just to the current frame.
Comment 1 Radar WebKit Bug Importer 2013-11-14 18:19:37 PST 
<rdar://problem/15476369>
Comment 2 Alexandru Chiculita 2013-11-14 18:30:42 PST 
Created attachment 217004 [details]
Patch V1
Comment 3 Timothy Hatcher 2013-11-15 10:55:27 PST 
Comment on attachment 217004 [details]
Patch V1

View in context: https://bugs.webkit.org/attachment.cgi?id=217004&action=review

> Source/WebCore/inspector/InspectorDOMAgent.cpp:888
>      // 2) There is no need to push all search results to the front-end at a time, pushing next / previous result
>      //    is sufficient.

You can remove this comment. It is not true anymore.
Comment 4 Alexandru Chiculita 2013-11-15 13:33:28 PST 
Created attachment 217076 [details]
Patch for landing

Thanks!
Comment 5 WebKit Commit Bot 2013-11-15 14:06:01 PST 
Comment on attachment 217076 [details]
Patch for landing

Clearing flags on attachment: 217076

Committed r159357: <http://trac.webkit.org/changeset/159357>
Comment 6 WebKit Commit Bot 2013-11-15 14:06:06 PST 
All reviewed patches have been landed.  Closing bug.