Bug 124380 - [Win] Improve support for command line build of 64-bit JSC
Summary: [Win] Improve support for command line build of 64-bit JSC
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-11-14 14:27 PST by Brent Fulgham
Modified: 2013-11-14 20:56 PST (History)
4 users (show)

See Also:

Attachments
Patch (2.60 KB, patch)
2013-11-14 14:31 PST, Brent Fulgham 		ddkilzer: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2013-11-14 14:27:39 PST 
The existing build scripts improperly include the "|x64" suffix to the build configuration when chaining scripts together, such as when using "run-javascriptcore-tests".

This patch removes this problem so that 32-bit and 64-bit JSC build and tests can be run from the command line.
Comment 1 Brent Fulgham 2013-11-14 14:31:21 PST 
Created attachment 216981 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2013-11-14 14:34:49 PST 
<rdar://problem/15473874>
Comment 3 David Kilzer (:ddkilzer) 2013-11-14 16:26:24 PST 
Comment on attachment 216981 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=216981&action=review

r=me!

> Tools/Scripts/webkitdirs.pm:377
> +    push(@args, '--debug') if ($configuration =~ "Debug");
> +    push(@args, '--release') if ($configuration =~ "Release");

Nit:  Maybe match on "^Debug" and "^Release"  Or do you want other (less valid) things to work as well?
Comment 4 Brent Fulgham 2013-11-14 20:56:05 PST 
Committed r159328: <http://trac.webkit.org/changeset/159328>
Comment 5 Brent Fulgham 2013-11-14 20:56:49 PST 
I incorporated David's improvement.