Bug 124360 - [GTK] Bumping GStreamer version to 1.2.1 for the dependencies
Summary: [GTK] Bumping GStreamer version to 1.2.1 for the dependencies
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Xabier Rodríguez Calvar
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-14 08:26 PST by Xabier Rodríguez Calvar
Modified: 2013-11-15 02:21 PST (History)
2 users (show)

See Also:

Attachments
Patch (7.01 KB, patch)
2013-11-14 08:36 PST, Xabier Rodríguez Calvar 		no flags Details | Formatted Diff | Diff
Patch (6.49 KB, patch)
2013-11-14 09:48 PST, Xabier Rodríguez Calvar 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Xabier Rodríguez Calvar 2013-11-14 08:26:51 PST 
[GTK] Bumping GStreamer version to 1.2.1 for the dependencies
Comment 1 Xabier Rodríguez Calvar 2013-11-14 08:36:41 PST 
Created attachment 216940 [details]
Patch

Bumped version up to 1.2.1, disabled GTK doc generation at the dependencies and flagged possible regression.
Comment 2 Philippe Normand 2013-11-14 08:41:23 PST 
Comment on attachment 216940 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=216940&action=review

> Tools/gtk/jhbuildrc:60
> +autogenargs='--enable-introspection --disable-gtk-doc'

that will disable doc build for webkit too, no?

> LayoutTests/platform/gtk/TestExpectations:1425
> +webkit.org/b/124360 media/video-canvas-drawing-output.html [ Failure ]

ah sorry i thought you'd open a new bug. oh well we can change this later
Comment 3 Xabier Rodríguez Calvar 2013-11-14 09:05:21 PST 
(In reply to comment #2)
> (From update of attachment 216940 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=216940&action=review
> 
> > Tools/gtk/jhbuildrc:60
> > +autogenargs='--enable-introspection --disable-gtk-doc'
> 
> that will disable doc build for webkit too, no?

I thought it would only apply to the dependencies but it is working for WebKit too.
Comment 4 Xabier Rodríguez Calvar 2013-11-14 09:48:37 PST 
Created attachment 216953 [details]
Patch

Removed the GTK doc stuff, that I will do in another bug when disabling tests too.
Comment 5 Philippe Normand 2013-11-14 10:31:33 PST 
Comment on attachment 216953 [details]
Patch

Perhaps better to land this tomorrow so it's easier to keep an eye on the bots
Comment 6 Xabier Rodríguez Calvar 2013-11-14 11:21:22 PST 
(In reply to comment #5)
> (From update of attachment 216953 [details])
> Perhaps better to land this tomorrow so it's easier to keep an eye on the bots

Thought about it already.
Comment 7 WebKit Commit Bot 2013-11-15 02:21:34 PST 
Comment on attachment 216953 [details]
Patch

Clearing flags on attachment: 216953

Committed r159330: <http://trac.webkit.org/changeset/159330>
Comment 8 WebKit Commit Bot 2013-11-15 02:21:36 PST 
All reviewed patches have been landed.  Closing bug.