Bug 124360 – [GTK] Bumping GStreamer version to 1.2.1 for the dependencies

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Xabier Rodríguez Calvar]

[GTK] Bumping GStreamer version to 1.2.1 for the dependencies

[Xabier Rodríguez Calvar]

Created attachment 216940 [details]
Patch

Bumped version up to 1.2.1, disabled GTK doc generation at the dependencies and flagged possible regression.

[Philippe Normand]

Comment on attachment 216940 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=216940&action=review

> Tools/gtk/jhbuildrc:60
> +autogenargs='--enable-introspection --disable-gtk-doc'

that will disable doc build for webkit too, no?

> LayoutTests/platform/gtk/TestExpectations:1425
> +webkit.org/b/124360 media/video-canvas-drawing-output.html [ Failure ]

ah sorry i thought you'd open a new bug. oh well we can change this later

[Xabier Rodríguez Calvar]

(In reply to comment #2)
> (From update of attachment 216940 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=216940&action=review
> 
> > Tools/gtk/jhbuildrc:60
> > +autogenargs='--enable-introspection --disable-gtk-doc'
> 
> that will disable doc build for webkit too, no?

I thought it would only apply to the dependencies but it is working for WebKit too.

[Xabier Rodríguez Calvar]

Created attachment 216953 [details]
Patch

Removed the GTK doc stuff, that I will do in another bug when disabling tests too.

[Philippe Normand]

Comment on attachment 216953 [details]
Patch

Perhaps better to land this tomorrow so it's easier to keep an eye on the bots

[Xabier Rodríguez Calvar]

(In reply to comment #5)
> (From update of attachment 216953 [details])
> Perhaps better to land this tomorrow so it's easier to keep an eye on the bots

Thought about it already.

[WebKit Commit Bot]

Comment on attachment 216953 [details]
Patch

Clearing flags on attachment: 216953

Committed r159330: <http://trac.webkit.org/changeset/159330>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.