Bug 124359 - Make CLoop easier to build, and make it work
Summary: Make CLoop easier to build, and make it work
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Oliver Hunt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-14 08:19 PST by Oliver Hunt
Modified: 2013-11-14 16:10 PST (History)
4 users (show)

See Also:


Attachments
Patch (23.19 KB, patch)
2013-11-14 08:26 PST, Oliver Hunt
no flags Details | Formatted Diff | Diff
Patch (26.62 KB, patch)
2013-11-14 16:03 PST, Oliver Hunt
ggaren: review+
Details | Formatted Diff | Diff
Patch (26.48 KB, patch)
2013-11-14 16:06 PST, Oliver Hunt
ggaren: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Oliver Hunt 2013-11-14 08:19:48 PST
Make CLoop easier to build, and make it work
Comment 1 Oliver Hunt 2013-11-14 08:26:15 PST
Created attachment 216939 [details]
Patch
Comment 2 Geoffrey Garen 2013-11-14 08:30:23 PST
Comment on attachment 216939 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=216939&action=review

r=me

Please fix stray comment markers.

> Source/JavaScriptCore/jit/JITExceptions.cpp:56
> +//        catchRoutine = vm->getCTIStub(throwNotCaught).code().executableAddress();

Maybe you meant an #ifdef here?

> Source/WTF/wtf/Platform.h:34
> +//#if defined(ENABLE_LLINT_C_LOOP) && ENABLE_LLINT_C_LOOP

Remove comment markers?
Comment 3 Oliver Hunt 2013-11-14 08:31:37 PST
(In reply to comment #2)
> (From update of attachment 216939 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=216939&action=review
> 
> r=me
> 
> Please fix stray comment markers.
> 
> > Source/JavaScriptCore/jit/JITExceptions.cpp:56
> > +//        catchRoutine = vm->getCTIStub(throwNotCaught).code().executableAddress();
> 
> Maybe you meant an #ifdef here?
Yup :-D

> 
> > Source/WTF/wtf/Platform.h:34
> > +//#if defined(ENABLE_LLINT_C_LOOP) && ENABLE_LLINT_C_LOOP
> 
> Remove comment markers?

Yup, i'm just seeing what happens to the EWS bots
Comment 4 Oliver Hunt 2013-11-14 16:03:05 PST
Created attachment 216993 [details]
Patch
Comment 5 Oliver Hunt 2013-11-14 16:06:20 PST
Created attachment 216994 [details]
Patch
Comment 6 Geoffrey Garen 2013-11-14 16:06:50 PST
Comment on attachment 216993 [details]
Patch

r=me
Comment 7 Oliver Hunt 2013-11-14 16:10:42 PST
Committed r159321: <http://trac.webkit.org/changeset/159321>