Bug 124350 – Web Inspector: Popovers may shrink unnecessarily

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Antoine Quint]

Because we always get the intersection of the preferred frame and the container frame to ensure the popover fits within its container based on a preferred frame that would place the arrow within the center of the attachment edge, we get in situations where we may shrink the popover instead of shifting it to fit within the container frame.

[Radar WebKit Bug Importer]

<rdar://problem/15469207>

[Antoine Quint]

Created attachment 216930 [details]
Patch

[Timothy Hatcher]

Comment on attachment 216930 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=216930&action=review

> Source/WebInspectorUI/UserInterface/Popover.js:402
> +            x += containerFrame.maxX() - (x + width);

+= does not sound right. Should this just be =?

> Source/WebInspectorUI/UserInterface/Popover.js:404
> +            y += containerFrame.maxY() - (y + height);

Ditto.

[Timothy Hatcher]

Comment on attachment 216930 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=216930&action=review

>> Source/WebInspectorUI/UserInterface/Popover.js:402
>> +            x += containerFrame.maxX() - (x + width);
> 
> += does not sound right. Should this just be =?

Never mind. It will always be negative.

[WebKit Commit Bot]

Comment on attachment 216930 [details]
Patch

Clearing flags on attachment: 216930

Committed r159286: <http://trac.webkit.org/changeset/159286>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Antoine Quint]

This caused a regression, see https://bugs.webkit.org/show_bug.cgi?id=125069.