Bug 124347 - REGRESSION(r159276): Lots of crashes for sh4 arch
Summary: REGRESSION(r159276): Lots of crashes for sh4 arch
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 124344
Blocks:
  Show dependency tree / graph
 
Reported: 2013-11-14 05:18 PST by Julien Brianceau
Modified: 2013-11-14 08:50 PST (History)
4 users (show)

See Also:

Attachments
Prevent argument register trampling in cCallX macros of LLINT for sh4. (6.80 KB, patch)
2013-11-14 07:40 PST, Julien Brianceau 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Julien Brianceau 2013-11-14 05:18:20 PST 
Lots of crashes appeared for sh4 architecture since http://trac.webkit.org/changeset/159276

The issue is identified and I'll submit a patch soon
Comment 1 Julien Brianceau 2013-11-14 07:40:51 PST 
Created attachment 216933 [details]
Prevent argument register trampling in cCallX macros of LLINT for sh4.

This patch fixes the crashes.

If I have time and if you think it's worth, I could move this "setargs" from SH4_INSTRUCTIONS to RISC_INSTRUCTIONS later, as I think this issue could also occur with ARM & MIPS architectures.
Comment 2 WebKit Commit Bot 2013-11-14 08:50:37 PST 
Comment on attachment 216933 [details]
Prevent argument register trampling in cCallX macros of LLINT for sh4.

Clearing flags on attachment: 216933

Committed r159288: <http://trac.webkit.org/changeset/159288>
Comment 3 WebKit Commit Bot 2013-11-14 08:50:39 PST 
All reviewed patches have been landed.  Closing bug.