Bug 124343 – Clean up sequence handling in Blob constructor

• Status: RESOLVED
• Resolution: FIXED
• Component: Bindings

[Victor Costan]

This is a follow-up to Alexey Proskuryakov's feedback on https://bugs.webkit.org/show_bug.cgi?id=124175

[Victor Costan]

Created attachment 216917 [details]
Patch

[Victor Costan]

The LayoutTest I added actually works without the new exception check. I think it's still valuable because it demonstrates correct behavior, and it uncovered a crashing bug in the Blink patch for the same feature.

[Chris Dumez]

Comment on attachment 216917 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=216917&action=review

> Source/WebCore/bindings/js/JSBlobCustom.cpp:124
> +            blobBuilder.append(arrayBufferView);

nit: We might want to arrayBufferView.release() to avoid some ref counting churn.

[Victor Costan]

Created attachment 216991 [details]
Patch

[Victor Costan]

Thank you for catching that, Chris! Can you please take another look?

[Chris Dumez]

(In reply to comment #5)
> Thank you for catching that, Chris! Can you please take another look?

No need for additional review, it was merely a nit.

Just update the Changelog to indicate that it was reviewed by Alexey and reupload with the cq+ flag only.

[Victor Costan]

Created attachment 216995 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 216995 [details]
Patch

Rejecting attachment 216995 [details] from commit-queue.

[e-mail] does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.

[Victor Costan]

Chris, it seems like I'm not cool enough to use CQ directly.

Sorry, it seems like you and/or Alexey will have to r+ the patch.

[Chris Dumez]

(In reply to comment #9)
> Chris, it seems like I'm not cool enough to use CQ directly.
> 
> Sorry, it seems like you and/or Alexey will have to r+ the patch.

Sorry I meant that you should set the cq? flag (not cq+ since you're not a committer). It is OK, I cq+ for you.

[Victor Costan]

Sorry to cause you extra work, Chris! I'll know better next time! :)

Thanks!!

[WebKit Commit Bot]

Comment on attachment 216995 [details]
Patch

Clearing flags on attachment: 216995

Committed r159323: <http://trac.webkit.org/changeset/159323>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.