Bug 124338 – FontDescription copies should share families list, not duplicate it.

• Status: RESOLVED
• Resolution: FIXED
• Component: Text

[Andreas Kling]

Potential savings here. We have a looooot of FontDescription copies thanks to copy-on-write StyleInheritedData.

[Andreas Kling]

Created attachment 216909 [details]
Patch

[Antti Koivisto]

Comment on attachment 216909 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=216909&action=review

> Source/WebCore/platform/graphics/FontDescription.h:235
> +inline bool FontDescription::hasEqualFamilies(const FontDescription& other) const
> +{
> +    if (m_families.data() == other.m_families.data())
> +        return true;
> +    if (m_families.size() != other.m_families.size())
> +        return false;
> +    for (unsigned i = 0; i < m_families.size(); ++i) {
> +        if (m_families[i] != other.m_families[i])
> +            return false;
> +    }
> +    return true;
> +}

Seems more like this could be operator== or equals in RefCountedArray

[Andreas Kling]

Committed r159279: <http://trac.webkit.org/changeset/159279>