Bug 124324 - [CSS Shapes] Empty polygons with non-zero shape-padding cause an ASSERT crash
Summary: [CSS Shapes] Empty polygons with non-zero shape-padding cause an ASSERT crash
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Hans Muller
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-13 17:32 PST by Hans Muller
Modified: 2013-11-14 10:19 PST (History)
5 users (show)

See Also:


Attachments
Test case (219 bytes, text/html)
2013-11-13 17:32 PST, Hans Muller
no flags Details
Patch (5.93 KB, patch)
2013-11-13 19:52 PST, Hans Muller
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hans Muller 2013-11-13 17:32:38 PST
Created attachment 216881 [details]
Test case

Polygon shape-inside values with less than three vertices and non-zero shape-padding cause an ASSERT crash. The same is true for shape-outside polygons and shape-margin.
Comment 1 Hans Muller 2013-11-13 19:52:13 PST
Created attachment 216891 [details]
Patch

PolygonShape::shapePaddingBounds() and PolygonShape::shapeMarginBounds() no longer attempt to compute a new FloatPolygon when the original is empty, i.e. when it has less than three vertices.
Comment 2 Andreas Kling 2013-11-14 09:39:10 PST
Comment on attachment 216891 [details]
Patch

r=me
Comment 3 WebKit Commit Bot 2013-11-14 10:19:18 PST
Comment on attachment 216891 [details]
Patch

Clearing flags on attachment: 216891

Committed r159291: <http://trac.webkit.org/changeset/159291>
Comment 4 WebKit Commit Bot 2013-11-14 10:19:19 PST
All reviewed patches have been landed.  Closing bug.