Bug 124315 - Fix the ARM64 build after recent JavaScriptCore changes
Summary: Fix the ARM64 build after recent JavaScriptCore changes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andy Estes
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-13 15:28 PST by Andy Estes
Modified: 2013-11-13 16:42 PST (History)
1 user (show)

See Also:


Attachments
Fix the ARM64 build after recent JavaScriptCore changes (15.09 KB, patch)
2013-11-13 15:37 PST, Andy Estes
msaboff: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Estes 2013-11-13 15:28:36 PST
Fix the ARM64 build after recent JavaScriptCore changes
Comment 1 Andy Estes 2013-11-13 15:37:23 PST
Created attachment 216874 [details]
Fix the ARM64 build after recent JavaScriptCore changes
Comment 2 Michael Saboff 2013-11-13 16:10:11 PST
Comment on attachment 216874 [details]
Fix the ARM64 build after recent JavaScriptCore changes

View in context: https://bugs.webkit.org/attachment.cgi?id=216874&action=review

r+,  make the fixes noted.

> Source/JavaScriptCore/assembler/MacroAssemblerARM64.h:539
> +        lshift64(dest, shiftAmount, dest);

This needs to be rshift64.

> Source/JavaScriptCore/assembler/MacroAssemblerARM64.h:544
> +        lshift64(dest, imm, dest);

This needs to be rshift64.
Comment 3 Andy Estes 2013-11-13 16:42:25 PST
Committed r159261: <http://trac.webkit.org/changeset/159261>