SVGTransform SVGAnimateTransformElement::parseTransformValue(const String& data) const
should find a way to share code. Having two just means we'll parse some things wrong, and be open to more possible parser-related security holes.
Created attachment 14840 [details]
This patch works in general, not really tested for the animation stuff.
Comment on attachment 14840 [details]
The assignment here doesn't ned to be on separate lines:
+ SVGTransformable::parseTransformValue(m_type, ptr, ptr + m_from.length(), t);
+ m_fromTransform = t;
You could just pass m_fromTransform (if you're not gonna check the bool return anyway)
Personally I might give required/optional longer names. Like requireParamsForTransformType or even requiredForType or something.
Neither of those are functional issues. I'm perhaps still too asleep give this a careful review. More later.
Created attachment 14873 [details]
slightly improved version of rob's patch, fixing one bug
Landed on the feature-branch as r22021.