Bug 124279 - Factor simple line creation loop to function
Summary: Factor simple line creation loop to function
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-13 06:54 PST by Antti Koivisto
Modified: 2013-11-13 07:33 PST (History)
4 users (show)

See Also:


Attachments
patch (16.54 KB, patch)
2013-11-13 07:13 PST, Antti Koivisto
kling: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2013-11-13 06:54:42 PST
refactor
Comment 1 Antti Koivisto 2013-11-13 07:13:14 PST
Created attachment 216798 [details]
patch
Comment 2 WebKit Commit Bot 2013-11-13 07:15:23 PST
Attachment 216798 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/rendering/SimpleLineLayout.cpp']" exit_code: 1
Source/WebCore/rendering/SimpleLineLayout.cpp:260:  Extra space after ( in function call  [whitespace/parens] [4]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Antti Koivisto 2013-11-13 07:33:58 PST
https://trac.webkit.org/r159194