WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
124279
Factor simple line creation loop to function
https://bugs.webkit.org/show_bug.cgi?id=124279
Summary
Factor simple line creation loop to function
Antti Koivisto
Reported
2013-11-13 06:54:42 PST
refactor
Attachments
patch
(16.54 KB, patch)
2013-11-13 07:13 PST
,
Antti Koivisto
kling
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Antti Koivisto
Comment 1
2013-11-13 07:13:14 PST
Created
attachment 216798
[details]
patch
WebKit Commit Bot
Comment 2
2013-11-13 07:15:23 PST
Attachment 216798
[details]
did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/rendering/SimpleLineLayout.cpp']" exit_code: 1 Source/WebCore/rendering/SimpleLineLayout.cpp:260: Extra space after ( in function call [whitespace/parens] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Antti Koivisto
Comment 3
2013-11-13 07:33:58 PST
https://trac.webkit.org/r159194
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug