WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
124264
Clean up static_cast<SVGFoo*> use
https://bugs.webkit.org/show_bug.cgi?id=124264
Summary
Clean up static_cast<SVGFoo*> use
Gyuyoung Kim
Reported
2013-11-12 23:02:45 PST
toSVGFoo() supports more plenty helper functions. So, we need to use it instead of static_cast<SVGFooElement*>.
Attachments
Patch
(6.82 KB, patch)
2013-11-13 00:01 PST
,
Gyuyoung Kim
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Gyuyoung Kim
Comment 1
2013-11-13 00:01:47 PST
Created
attachment 216774
[details]
Patch
WebKit Commit Bot
Comment 2
2013-11-13 16:13:11 PST
Comment on
attachment 216774
[details]
Patch Rejecting
attachment 216774
[details]
from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 216774, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit /Volumes/Data/EWS/WebKit/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output:
http://webkit-queues.appspot.com/results/22720019
Dirk Schulze
Comment 3
2014-03-19 04:31:16 PDT
Could you please land this patch? Thanks.
Dirk Schulze
Comment 4
2014-05-12 15:38:48 PDT
Either this landed already or someone else fixed it.
Gyuyoung Kim
Comment 5
2014-05-12 16:46:03 PDT
(In reply to
comment #4
)
> Either this landed already or someone else fixed it.
Clearing r+,cq-
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug