Bug 124258 - API::Object::Type should be a strongly typed enum
Summary: API::Object::Type should be a strongly typed enum
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-12 18:42 PST by Anders Carlsson
Modified: 2013-11-13 09:58 PST (History)
11 users (show)

See Also:

Attachments
Patch (87.75 KB, patch)
2013-11-12 18:43 PST, Anders Carlsson 		thorton: review+
eflews.bot: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2013-11-12 18:42:33 PST 
API::Object::Type should be a strongly typed enum
Comment 1 Anders Carlsson 2013-11-12 18:43:50 PST 
Created attachment 216762 [details]
Patch
Comment 2 EFL EWS Bot 2013-11-12 19:45:20 PST 
Comment on attachment 216762 [details]
Patch

Attachment 216762 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/22938631
Comment 3 Gyuyoung Kim 2013-11-12 23:54:36 PST 
It looks this patch needs to support WK2 classes which used by GTK and EFL WK2 additionally. Please refer to http://trac.webkit.org/changeset/159176.
Comment 4 Anders Carlsson 2013-11-13 08:17:50 PST 
Committed r159197: <http://trac.webkit.org/changeset/159197>
Comment 5 Csaba Osztrogonác 2013-11-13 09:20:09 PST 
(In reply to comment #4)
> Committed r159197: <http://trac.webkit.org/changeset/159197>

I'm working on the fix now, will commit soon.
Comment 6 Brendan Long 2013-11-13 09:35:31 PST 
> I'm working on the fix now, will commit soon.

Sorry, I didn't realize someone else was already working on this until after I finished my patch. Can someone review the patch on bug #124289?
Comment 7 Csaba Osztrogonác 2013-11-13 09:58:06 PST 
fixes landed in
- https://trac.webkit.org/changeset/159204
- https://trac.webkit.org/changeset/159206