RESOLVED FIXED 124258
API::Object::Type should be a strongly typed enum 
https://bugs.webkit.org/show_bug.cgi?id=124258
Summary API::Object::Type should be a strongly typed enum
Anders Carlsson
Reported 2013-11-12 18:42:33 PST
API::Object::Type should be a strongly typed enum
Attachments
Patch (87.75 KB, patch)
2013-11-12 18:43 PST, Anders Carlsson 		thorton: review+
eflews.bot: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2013-11-12 18:43:50 PST
Created attachment 216762 [details] Patch
EFL EWS Bot
Comment 2 2013-11-12 19:45:20 PST
Comment on attachment 216762 [details] Patch Attachment 216762 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/22938631
Gyuyoung Kim
Comment 3 2013-11-12 23:54:36 PST
It looks this patch needs to support WK2 classes which used by GTK and EFL WK2 additionally. Please refer to http://trac.webkit.org/changeset/159176.
Anders Carlsson
Comment 4 2013-11-13 08:17:50 PST
Committed r159197: <http://trac.webkit.org/changeset/159197>
Csaba Osztrogonác
Comment 5 2013-11-13 09:20:09 PST
(In reply to comment #4) > Committed r159197: <http://trac.webkit.org/changeset/159197> I'm working on the fix now, will commit soon.
Brendan Long
Comment 6 2013-11-13 09:35:31 PST
> I'm working on the fix now, will commit soon. Sorry, I didn't realize someone else was already working on this until after I finished my patch. Can someone review the patch on bug #124289?
Csaba Osztrogonác
Comment 7 2013-11-13 09:58:06 PST
fixes landed in - https://trac.webkit.org/changeset/159204 - https://trac.webkit.org/changeset/159206
Note You need to log in before you can comment on or make changes to this bug.