WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
124252
[Mac] Fix some deprecation warnings
https://bugs.webkit.org/show_bug.cgi?id=124252
Summary
[Mac] Fix some deprecation warnings
Andy Estes
Reported
2013-11-12 17:26:19 PST
[Mac] Fix some deprecation warnings
Attachments
[Mac] Fix some deprecation warnings
(7.69 KB, patch)
2013-11-12 17:32 PST
,
Andy Estes
mrowe
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Andy Estes
Comment 1
2013-11-12 17:32:40 PST
Created
attachment 216752
[details]
[Mac] Fix some deprecation warnings
Mark Rowe (bdash)
Comment 2
2013-11-12 17:52:40 PST
Comment on
attachment 216752
[details]
[Mac] Fix some deprecation warnings View in context:
https://bugs.webkit.org/attachment.cgi?id=216752&action=review
> Source/WebCore/platform/mac/HTMLConverter.mm:1536 > + dateComponents.get().timeZone = [NSTimeZone timeZoneForSecondsFromGMT:0];
I think it's conventional to do [dateComponents setTimeZone:…]; rather than calling .get() just to use the property syntax. Similarly for the use of getters below.
Andy Estes
Comment 3
2013-11-12 18:02:22 PST
Committed
r159171
: <
http://trac.webkit.org/changeset/159171
>
Andy Estes
Comment 4
2013-11-12 18:17:49 PST
Landed a build fix for Mountain Lion in
http://trac.webkit.org/changeset/159172
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug