Bug 124252 - [Mac] Fix some deprecation warnings
Summary: [Mac] Fix some deprecation warnings
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andy Estes
Depends on:
Reported: 2013-11-12 17:26 PST by Andy Estes
Modified: 2013-11-12 18:17 PST (History)
2 users (show)

See Also:

[Mac] Fix some deprecation warnings (7.69 KB, patch)
2013-11-12 17:32 PST, Andy Estes
mrowe: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Estes 2013-11-12 17:26:19 PST
[Mac] Fix some deprecation warnings
Comment 1 Andy Estes 2013-11-12 17:32:40 PST
Created attachment 216752 [details]
[Mac] Fix some deprecation warnings
Comment 2 Mark Rowe (bdash) 2013-11-12 17:52:40 PST
Comment on attachment 216752 [details]
[Mac] Fix some deprecation warnings

View in context: https://bugs.webkit.org/attachment.cgi?id=216752&action=review

> Source/WebCore/platform/mac/HTMLConverter.mm:1536
> +    dateComponents.get().timeZone = [NSTimeZone timeZoneForSecondsFromGMT:0];

I think it's conventional to do [dateComponents setTimeZone:…]; rather than calling .get() just to use the property syntax. Similarly for the use of getters below.
Comment 3 Andy Estes 2013-11-12 18:02:22 PST
Committed r159171: <http://trac.webkit.org/changeset/159171>
Comment 4 Andy Estes 2013-11-12 18:17:49 PST
Landed a build fix for Mountain Lion in http://trac.webkit.org/changeset/159172