Bug 124237 - Move ValueToString out to its own header file to remove duplication
Summary: Move ValueToString out to its own header file to remove duplication
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Bem Jones-Bey
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-12 15:22 PST by Bem Jones-Bey
Modified: 2013-11-12 16:29 PST (History)
8 users (show)

See Also:

Attachments
Patch (16.79 KB, patch)
2013-11-12 15:30 PST, Bem Jones-Bey 		no flags Details | Formatted Diff | Diff
Updated Patch (16.77 KB, patch)
2013-11-12 15:46 PST, Bem Jones-Bey 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Bem Jones-Bey 2013-11-12 15:22:07 PST 
Move ValueToString out to its own header file to remove duplication
Comment 1 Bem Jones-Bey 2013-11-12 15:30:36 PST 
Created attachment 216732 [details]
Patch
Comment 2 Alexandru Chiculita 2013-11-12 15:42:27 PST 
Comment on attachment 216732 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=216732&action=review

r=me

> Source/WebCore/platform/LayoutUnit.h:34
> +#ifndef NDEBUG

nit: You don't need the #ifndef here. The file itself already has it. Also, you don't do that in the other headers.

> Source/WebCore/platform/LayoutUnit.h:970
> +template <> struct ValueToString<LayoutUnit> {

nit: you have different styles for the template<> placement. I think the second one is better.

template <> struct ValueToString<LayoutUnit>

and 

template <>
struct ValueToString<LayoutUnit>
Comment 3 Bem Jones-Bey 2013-11-12 15:46:58 PST 
Created attachment 216735 [details]
Updated Patch
Comment 4 WebKit Commit Bot 2013-11-12 16:29:26 PST 
Comment on attachment 216735 [details]
Updated Patch

Clearing flags on attachment: 216735

Committed r159159: <http://trac.webkit.org/changeset/159159>
Comment 5 WebKit Commit Bot 2013-11-12 16:29:28 PST 
All reviewed patches have been landed.  Closing bug.