Bug 124230 - Web Inspector: ContentFlowTreeContentView should use only one DOMTreeOutline
Summary: Web Inspector: ContentFlowTreeContentView should use only one DOMTreeOutline
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Alexandru Chiculita
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-11-12 13:48 PST by Alexandru Chiculita
Modified: 2013-11-12 15:01 PST (History)
5 users (show)

See Also:

Attachments
Patch V1 (20.83 KB, patch)
2013-11-12 14:14 PST, Alexandru Chiculita 		no flags Details | Formatted Diff | Diff
Patch V2 (25.82 KB, patch)
2013-11-12 14:24 PST, Alexandru Chiculita 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexandru Chiculita 2013-11-12 13:48:44 PST 
Currently ContentFlowTreeContentView creates one DOMTreeOutline for each root element with "-webkit-flow-into". The issue is that DOMTreeOutline objects are disconnected, so navigation across root elements is also broken.

Also, ContentFlowTreeContentView tends to reimplement a lot of the DOMTreeContentView, so finding a way to inherit from it would save a lot of duplicated code.
Comment 1 Radar WebKit Bug Importer 2013-11-12 13:49:13 PST 
<rdar://problem/15452067>
Comment 2 Alexandru Chiculita 2013-11-12 14:14:05 PST 
Created attachment 216723 [details]
Patch V1
Comment 3 Alexandru Chiculita 2013-11-12 14:24:14 PST 
Created attachment 216725 [details]
Patch V2

Renamed ContentFlowTreeContentView to ContentFlowDOMTreeContentView to better reflect the inheritance of the object.
Comment 4 WebKit Commit Bot 2013-11-12 15:01:51 PST 
Comment on attachment 216725 [details]
Patch V2

Clearing flags on attachment: 216725

Committed r159151: <http://trac.webkit.org/changeset/159151>
Comment 5 WebKit Commit Bot 2013-11-12 15:01:53 PST 
All reviewed patches have been landed.  Closing bug.