Bug 124227 - [CSS Shapes] Accept the new <box> value for shape-outside
Summary: [CSS Shapes] Accept the new <box> value for shape-outside
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Bear Travis
URL:
Keywords:
Depends on:
Blocks: 124173
  Show dependency tree / graph
 
Reported: 2013-11-12 13:20 PST by Bear Travis
Modified: 2013-11-14 13:24 PST (History)
10 users (show)

See Also:

Attachments
Initial patch (29.71 KB, patch)
2013-11-13 13:29 PST, Bear Travis 		no flags Details | Formatted Diff | Diff
Updated patch (30.19 KB, patch)
2013-11-13 15:20 PST, Bear Travis 		no flags Details | Formatted Diff | Diff
Adding parsing tests and fixme (35.43 KB, patch)
2013-11-14 10:50 PST, Bear Travis 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Bear Travis 2013-11-12 13:20:36 PST 
http://dev.w3.org/csswg/css-shapes/#shape-outside-property adds the values [margin/border/padding/content]-box as valid values for shape properties.
Comment 1 Bear Travis 2013-11-13 13:29:25 PST 
Created attachment 216849 [details]
Initial patch
Comment 2 EFL EWS Bot 2013-11-13 13:47:44 PST 
Comment on attachment 216849 [details]
Initial patch

Attachment 216849 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/22869161
Comment 3 EFL EWS Bot 2013-11-13 14:02:20 PST 
Comment on attachment 216849 [details]
Initial patch

Attachment 216849 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/22780010
Comment 4 Bear Travis 2013-11-13 15:20:01 PST 
Created attachment 216872 [details]
Updated patch
Comment 5 Hans Muller 2013-11-14 09:43:49 PST 
Shouldn't this patch include new parsing tests in fast/shapes/parsing/?
Comment 6 Hans Muller 2013-11-14 09:52:30 PST 
> m_shape = Shape::createShape(m_shapeLogicalSize, LayoutSize(), writingMode, margin, padding);

This appears to be a stub, since the border radii have been punted. Might be a good place for a FIXME, see https://bugs.webkit.org/show_bug.cgi?id=124368
Comment 7 Bear Travis 2013-11-14 10:50:25 PST 
Created attachment 216961 [details]
Adding parsing tests and fixme
Comment 8 Dave Hyatt 2013-11-14 12:56:31 PST 
Comment on attachment 216961 [details]
Adding parsing tests and fixme

r=me
Comment 9 WebKit Commit Bot 2013-11-14 13:24:41 PST 
Comment on attachment 216961 [details]
Adding parsing tests and fixme

Clearing flags on attachment: 216961

Committed r159307: <http://trac.webkit.org/changeset/159307>
Comment 10 WebKit Commit Bot 2013-11-14 13:24:45 PST 
All reviewed patches have been landed.  Closing bug.