Bug 124212 – Modifying RTCSessionDescription object construction to match the spec

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Thiago de Barros Lacerda]

According to the spec the RTCSessionDescriptionInit parameter in RTCSessionDescription constructor is optional, which must not be nullable.
If the 'type' and 'sdp' keys are not present, the string object that stores them in the RTCSessionDescription class, must be null in those cases.
Also, if an object that is not a Dictionary is passed as argument to the constructor, an exception must be raised.

[Thiago de Barros Lacerda]

Created attachment 216694 [details]
Patch

[Thiago de Barros Lacerda]

This patch needs the hash generated by xcode, to put the new added file in xcode project files

[Thiago de Barros Lacerda]

Created attachment 216803 [details]
Rebased patch

[Eric Carlson]

Comment on attachment 216803 [details]
Rebased patch

View in context: https://bugs.webkit.org/attachment.cgi?id=216803&action=review

> Source/WebCore/ChangeLog:13
> +        According to the spec the RTCSessionDescriptionInit parameter in RTCSessionDescription constructor is optional,
> +        which must not be nullable.
> +        If the 'type' and/or 'sdp' keys are not present, the string object that stores them in the
> +        RTCSessionDescription class, must be null in those cases.
> +        Also, if an object that is not a Dictionary is passed as argument to the constructor, an exception must be
> +        raised.

Nit: I don't think the line breaks after each sentence aid readability. I would remove them.

> Source/WebCore/bindings/js/JSRTCSessionDescriptionCustom.cpp:46
> +            return throwVMError(exec, createTypeError(exec, "Optional description init argument of RTCSessionDescription must be a valid Dictionary"));

Nit: I would change this to "Optional RTCSessionDescription constructor argument must be a valid Dictionary"

[Thiago de Barros Lacerda]

Created attachment 216829 [details]
Patch

[Thiago de Barros Lacerda]

Eric, could you send me the patch to apply in xcode build files?

[Thiago de Barros Lacerda]

Created attachment 216841 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 216841 [details]
Patch for landing

Clearing flags on attachment: 216841

Committed r159230: <http://trac.webkit.org/changeset/159230>