Bug 124208 - Begin cleaning up handling of ImmutableArray vectors
Summary: Begin cleaning up handling of ImmutableArray vectors
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-12 09:07 PST by Anders Carlsson
Modified: 2013-11-12 09:38 PST (History)
4 users (show)

See Also:

Attachments
Patch (32.22 KB, patch)
2013-11-12 09:08 PST, Anders Carlsson 		kling: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2013-11-12 09:07:02 PST 
Begin cleaning up handling of ImmutableArray vectors
Comment 1 Anders Carlsson 2013-11-12 09:08:52 PST 
Created attachment 216683 [details]
Patch
Comment 2 Andreas Kling 2013-11-12 09:20:39 PST 
Comment on attachment 216683 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=216683&action=review

r=me

> Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:122
> +        hostnameStrings.append(WebString::create(hostname));

I thought this was supposed to be uncheckedAppend(). Is this intentional? Why aren't you using uncheckedAppend() here?
Comment 3 Anders Carlsson 2013-11-12 09:38:43 PST 
Committed r159117: <http://trac.webkit.org/changeset/159117>