Bug 124207 - Make the placed floats tree use LayoutUnit instead of int
Summary: Make the placed floats tree use LayoutUnit instead of int
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Bem Jones-Bey
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-12 08:22 PST by Bem Jones-Bey
Modified: 2013-11-12 17:30 PST (History)
5 users (show)

See Also:

Attachments
Patch (7.75 KB, patch)
2013-11-12 09:18 PST, Bem Jones-Bey 		no flags Details | Formatted Diff | Diff
New Patch (5.66 KB, patch)
2013-11-12 16:32 PST, Bem Jones-Bey 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Bem Jones-Bey 2013-11-12 08:22:31 PST 
Floats use LayoutUnits for all dimensions, it doesn't really make sense to be converting to ints for the placed floats tree.
Comment 1 Bem Jones-Bey 2013-11-12 09:18:15 PST 
Created attachment 216685 [details]
Patch
Comment 2 Bem Jones-Bey 2013-11-12 16:32:27 PST 
Created attachment 216740 [details]
New Patch
Comment 3 Alexandru Chiculita 2013-11-12 16:36:23 PST 
Comment on attachment 216740 [details]
New Patch

Looks good, r=me.
Comment 4 Bem Jones-Bey 2013-11-12 16:39:25 PST 
Comment on attachment 216740 [details]
New Patch

Note that there is a small but non-zero chance that this could cause small precision issues with tests when subpixel layout is enabled. I have run all of the tests locally, and have not seen any issues, so I don't expect there to be any new issues from this change.
Comment 5 WebKit Commit Bot 2013-11-12 17:30:28 PST 
Comment on attachment 216740 [details]
New Patch

Clearing flags on attachment: 216740

Committed r159166: <http://trac.webkit.org/changeset/159166>
Comment 6 WebKit Commit Bot 2013-11-12 17:30:30 PST 
All reviewed patches have been landed.  Closing bug.