Bug 124193 - Introduce IDBServerConnection (and start moving things to it)
Summary: Introduce IDBServerConnection (and start moving things to it)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-12 00:09 PST by Brady Eidson
Modified: 2013-11-12 13:30 PST (History)
8 users (show)

See Also:

Attachments
Patch v1 (75.27 KB, patch)
2013-11-12 00:13 PST, Brady Eidson 		eflews.bot: commit-queue-
Details | Formatted Diff | Diff
Patch v2 - Implement dtor (75.34 KB, patch)
2013-11-12 00:22 PST, Brady Eidson 		eflews.bot: commit-queue-
Details | Formatted Diff | Diff
Patch v3 (75.33 KB, patch)
2013-11-12 00:43 PST, Brady Eidson 		ap: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2013-11-12 00:09:29 PST 
Introduce IDBServerConnection (and start moving things to it)

IDBServerConnection will be a purely asynchronous interface for the database connection, transactions, and cursors.

It's interface will be 100% asynchronous and callback based.

Eventually none of the IDB*Backend classes will need IDBBackingStore* classes at all, and will use IDBServerConnection instead
Comment 1 Brady Eidson 2013-11-12 00:13:57 PST 
Created attachment 216644 [details]
Patch v1
Comment 2 EFL EWS Bot 2013-11-12 00:19:52 PST 
Comment on attachment 216644 [details]
Patch v1 

Attachment 216644 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/22749454
Comment 3 Brady Eidson 2013-11-12 00:22:33 PST 
Created attachment 216645 [details]
Patch v2 - Implement dtor
Comment 4 EFL EWS Bot 2013-11-12 00:32:08 PST 
Comment on attachment 216645 [details]
Patch v2 - Implement dtor

Attachment 216645 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/22699675
Comment 5 kov's GTK+ EWS bot 2013-11-12 00:41:00 PST 
Comment on attachment 216645 [details]
Patch v2 - Implement dtor

Attachment 216645 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/22908597
Comment 6 Brady Eidson 2013-11-12 00:43:03 PST 
Created attachment 216648 [details]
Patch v3
Comment 7 Alexey Proskuryakov 2013-11-12 13:12:16 PST 
Comment on attachment 216648 [details]
Patch v3

View in context: https://bugs.webkit.org/attachment.cgi?id=216648&action=review

> Source/WebCore/Modules/indexeddb/IDBServerConnection.h:40
> +// This interface is meant to provide a single asynchronous layer between the web-facing frontend

Does it provide what it means to provide? The comment should either be more assertive, or a specific FIXME.

> Source/WebCore/Modules/indexeddb/IDBServerConnection.h:42
> +// If the completion of an operation is important monitoring it must be through the use of a callback function.

Important?

> Source/WebCore/Modules/indexeddb/leveldb/IDBServerConnectionLevelDB.cpp:29
> +#include "IDBBackingStoreInterface.h"

Is there a reason why this is outside ifdefs?

We usually put headers inside ifdefs in cpp files, and outside ifdefs in headers.
Comment 8 Brady Eidson 2013-11-12 13:30:06 PST 
http://trac.webkit.org/changeset/159144