RESOLVED FIXED124193
Introduce IDBServerConnection (and start moving things to it) 
https://bugs.webkit.org/show_bug.cgi?id=124193
Summary Introduce IDBServerConnection (and start moving things to it)
Brady Eidson
Reported 2013-11-12 00:09:29 PST
Introduce IDBServerConnection (and start moving things to it) IDBServerConnection will be a purely asynchronous interface for the database connection, transactions, and cursors. It's interface will be 100% asynchronous and callback based. Eventually none of the IDB*Backend classes will need IDBBackingStore* classes at all, and will use IDBServerConnection instead
Attachments
Patch v1 (75.27 KB, patch)
2013-11-12 00:13 PST, Brady Eidson 		eflews.bot: commit-queue-
DetailsFormatted DiffDiff
Patch v2 - Implement dtor (75.34 KB, patch)
2013-11-12 00:22 PST, Brady Eidson 		eflews.bot: commit-queue-
DetailsFormatted DiffDiff
Patch v3 (75.33 KB, patch)
2013-11-12 00:43 PST, Brady Eidson 		ap: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2013-11-12 00:13:57 PST
Created attachment 216644 [details] Patch v1
EFL EWS Bot
Comment 2 2013-11-12 00:19:52 PST
Comment on attachment 216644 [details] Patch v1 Attachment 216644 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/22749454
Brady Eidson
Comment 3 2013-11-12 00:22:33 PST
Created attachment 216645 [details] Patch v2 - Implement dtor
EFL EWS Bot
Comment 4 2013-11-12 00:32:08 PST
Comment on attachment 216645 [details] Patch v2 - Implement dtor Attachment 216645 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/22699675
kov's GTK+ EWS bot
Comment 5 2013-11-12 00:41:00 PST
Comment on attachment 216645 [details] Patch v2 - Implement dtor Attachment 216645 [details] did not pass gtk-ews (gtk): Output: http://webkit-queues.appspot.com/results/22908597
Brady Eidson
Comment 6 2013-11-12 00:43:03 PST
Created attachment 216648 [details] Patch v3
Alexey Proskuryakov
Comment 7 2013-11-12 13:12:16 PST
Comment on attachment 216648 [details] Patch v3 View in context: https://bugs.webkit.org/attachment.cgi?id=216648&action=review > Source/WebCore/Modules/indexeddb/IDBServerConnection.h:40 > +// This interface is meant to provide a single asynchronous layer between the web-facing frontend Does it provide what it means to provide? The comment should either be more assertive, or a specific FIXME. > Source/WebCore/Modules/indexeddb/IDBServerConnection.h:42 > +// If the completion of an operation is important monitoring it must be through the use of a callback function. Important? > Source/WebCore/Modules/indexeddb/leveldb/IDBServerConnectionLevelDB.cpp:29 > +#include "IDBBackingStoreInterface.h" Is there a reason why this is outside ifdefs? We usually put headers inside ifdefs in cpp files, and outside ifdefs in headers.
Brady Eidson
Comment 8 2013-11-12 13:30:06 PST
http://trac.webkit.org/changeset/159144
Note You need to log in before you can comment on or make changes to this bug.