Bug 124190 - Web Inspector: Extract InspectorAgentRegistry from InspectorBaseAgent
Summary: Web Inspector: Extract InspectorAgentRegistry from InspectorBaseAgent
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-11-11 23:08 PST by Joseph Pecoraro
Modified: 2013-11-12 16:51 PST (History)
7 users (show)

See Also:


Attachments
[PATCH] Proposed Fix (Also for bots) (26.08 KB, patch)
2013-11-11 23:10 PST, Joseph Pecoraro
timothy: review+
Details | Formatted Diff | Diff
[PATCH] Updated for Bots (26.04 KB, patch)
2013-11-12 12:52 PST, Joseph Pecoraro
buildbot: commit-queue-
Details | Formatted Diff | Diff
[PATCH] Updated for Bots 2 (26.12 KB, patch)
2013-11-12 13:39 PST, Joseph Pecoraro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2013-11-11 23:08:21 PST
Move InspectorAgentRegistry into its own .h/.cpp for clarity.
Comment 1 Radar WebKit Bug Importer 2013-11-11 23:08:36 PST
<rdar://problem/15445565>
Comment 2 Joseph Pecoraro 2013-11-11 23:10:08 PST
Created attachment 216639 [details]
[PATCH] Proposed Fix (Also for bots)
Comment 3 Joseph Pecoraro 2013-11-12 12:52:09 PST
Created attachment 216707 [details]
[PATCH] Updated for Bots
Comment 4 Build Bot 2013-11-12 13:35:31 PST
Comment on attachment 216707 [details]
[PATCH] Updated for Bots

Attachment 216707 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/22749607
Comment 5 Joseph Pecoraro 2013-11-12 13:39:43 PST
Created attachment 216718 [details]
[PATCH] Updated for Bots 2
Comment 6 WebKit Commit Bot 2013-11-12 16:51:54 PST
Comment on attachment 216718 [details]
[PATCH] Updated for Bots 2

Clearing flags on attachment: 216718

Committed r159162: <http://trac.webkit.org/changeset/159162>
Comment 7 WebKit Commit Bot 2013-11-12 16:51:56 PST
All reviewed patches have been landed.  Closing bug.